Remove all v3 deprecations#7409
Conversation
- setup.sh: use 'verdi profile setup core.psql_dos' and 'verdi profile set-default' (replacing removed 'verdi setup'/'verdi profile setdefault'); rewrite config/profile.yaml to the new option schema - Remove the legacy pytest-fixtures test and its CI step (module deleted) - Fix 27 mypy attr-defined errors surfaced by removing 'Node.__getattr__': cast load_node()/process-node accesses, declare 'BaseType._type', drop now-unused type-ignores, and fix 'verdi code duplicate' for portable codes (get_code_folder/get_code_rel_path never existed) - test_models: read attributes/extras/repository_metadata via the 'base' namespace now that the deprecated forwarding accessors are gone - Regenerate command_line.rst
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## v3 #7409 +/- ##
==========================================
+ Coverage 80.39% 80.44% +0.05%
==========================================
Files 578 572 -6
Lines 46128 45257 -871
==========================================
- Hits 37081 36402 -679
+ Misses 9047 8855 -192 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The v3 deprecation removal changed 'BaseRestartWorkChain.handler_overrides'
to require a per-handler dict ('{enabled, priority}') instead of a bool, so
the daemon system test's '{disabled_handler: True}' now fails port validation.
Use '{disabled_handler: {enabled: True}}'.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
1 participant
Removes all
version=3deprecations (deprecated Python API, CLI commands/options, re-export shim modules, and deprecated pytest fixtures); the load-only shimslegacy.Code,UpfData, andconvert_potentially_deprecated_entry_pointare intentionally kept so old data still loads.TODO:
All deprecations and their alternatives has to be listed one last time in change log v3