fix: [favicon] Fix favicon display for negative MurmurHash values

Author: Terrtia

bin/lib/objects/Favicons.py

@@ -118,21 +118,18 @@ def create(self, content):  # TODO first seen / last seen options
         dirname = os.path.dirname(filepath)
         if not os.path.exists(dirname):
             os.makedirs(dirname)
-        print(filepath)
         with open(filepath, 'wb') as f:
             f.write(content)
         self._create()
 
 def create(b_content, size_limit=5000000, b64=False, force=False):
-    print(type(b_content))
     if isinstance(b_content, str):
         b_content = b_content.encode()
-    print(type(b_content))
     b64 = base64.encodebytes(b_content)  # newlines inserted after every 76 bytes of output
     favicon_id = str(mmh3.hash(b64))
     favicon = Favicon(favicon_id)
-    # if not favicon.exists():
-    favicon.create(b_content)
+    if not favicon.exists():
+        favicon.create(b_content)
     return favicon
 
 class Favicons(AbstractDaterangeObjects):

var/www/blueprints/objects_favicon.py

@@ -37,8 +37,14 @@ def favicon(filename):
     if not filename:
         abort(404)
     filename = filename.replace('/', '')
-    if not 9 <= len(filename) <= 11 or not filename.isascii() or not filename.isalnum():
+    if not 9 <= len(filename) <= 11 or not filename.isascii():
         abort(404)
+    if filename.startswith('-'):
+        if not filename[1:].isalnum():
+            abort(404)
+    else:
+        if not filename.isalnum():
+            abort(404)
     fav = Favicons.Favicon(filename)
     return send_from_directory(Favicons.FAVICON_FOLDER, fav.get_rel_path(), as_attachment=False, mimetype='image')