Bugfix/369 gh action remote fix by ascheman · Pull Request #425 · aim42/htmlSanityCheck

ascheman · 2025-10-12T09:14:07Z

Just test the PR

to prepare Docker build and GH action as it contains HSC and all dependencies.

The primary goal is to provide a GitHub action. Additionally, we create and publish a multi-platform Docker image for usage in other scenarios (Standalone, GitLab CI, ...).

Execute the Docker integration test only if Docker is available.

Will only be pushed on successful build and test by GitHub workflow.

Switching off Docker push leads to ERROR: failed to build: docker exporter does not currently support exporting manifest lists

The integration test must run with a local image first

Locally we build for the respective platform and test with it. Then we build a multi-platform image and push that to the Registry.

Allow a push of the Docker image with additional tags to override or extend given images.

We only need the timestamped Docker images for some time to enable testing of certain builds.

and enable optional dry-run (default true)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

The container image usually should be there due to a previous build step

The container image must be there due to a previous build step

Pushing a Docker image (even for testing purposes) requires respective permissions.

We need to make sure the just build docker image is available for testing

github-actions · 2025-10-12T10:50:22Z

Test Results

123 files ±0 123 suites ±0 7m 36s ⏱️ - 5m 0s
487 tests ±0 485 ✅ ±0 0 💤 ±0 2 ❌ ±0
627 runs ±0 562 ✅ ±0 0 💤 ±0 65 ❌ ±0

For more details on these failures, see this check.

Results for commit 23e4907. ± Comparison against base commit 9efca5e.

This pull request removes 60 and adds 23 tests. Note that renamed tests count towards both.

                                <a href="http://aim.org">improve</a>' 
                                <a href="http://arc42.de">arc42.de</a> and some more text
                                <a href="https://arc42.org">arc42 over https</a> even more
                                <a href="local-file.jpg">local file</a> again, text
                                <img src="" alt="2">
                                <img src="t.doc" alt="r"> '
    <area shape="circle" coords="0,1,1" href="#test2">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
    <area shape="rect" coords="0,0,1,1" href="#test1" >
    <area shape="rect" coords="0,0,1,1" href="#test1">
…

org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <img src="image1.jpg" usemap="#map1"><map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<h2 id="foo" >bad header</h2>, msg: ImageMap "map1" refers to missing link "id1"., #4]
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <img src="image1.jpg" usemap="#map1"><map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<h2 id="id1">aim42 header</h2>, msg: 2 imagemaps with identical name "map1" exist., #1]
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <img src="image1.jpg" usemap="#map1"><map name="map1">
</map>
, msg: ImageMap "map1" has no area tags., #3]
org.aim42.htmlsanitycheck.check.ImageMapsCheckerSpec ‑ find image map issues [nrOfFindings: 1, imageMapStr: <map name="map1">
    <area shape="rect" coords="0,0,1,1" href="#id1" >
</map>
<h2 id="id1">aim42 header</h2>, msg: ImageMap "map1" not referenced by any image., #2]
org.aim42.htmlsanitycheck.html.HtmlPageSpec ‑ can extract alt attributes from imageTag ' <img alt="1" >
                                <img src="" alt="2">
                                <img src="t.doc" alt="r"> '
org.aim42.htmlsanitycheck.html.HtmlPageSpec ‑ detect correct number of external http links in anchors '<a href="http://arc42.org">arc42</a> and some text
                                <a href="http://arc42.de">arc42.de</a> and some more text
                                <a href="https://arc42.org">arc42 over https</a> even more
                                <a href="local-file.jpg">local file</a> again, text
                                <a href="http://aim.org">improve</a>' 
org.aim42.htmlsanitycheck.html.HtmlPageSpec ‑ detect missing alt attributes in imageTag ' <img alt="1" >
                                <img src="" alt="2">
                                <img src="t.doc" alt="r"> '
org.aim42.htmlsanitycheck.html.ImageMapParserSpec ‑ find all areas within map [nrOfAreas: 1, mapName: mymap, htmlBody: <img src="image.gif" usemap="#mymap">
<map name="mymap">
    <area shape="rect" coords="0,0,1,1" href="#test1" >
</map> , #1]
org.aim42.htmlsanitycheck.html.ImageMapParserSpec ‑ find all areas within map [nrOfAreas: 2, mapName: mymap, htmlBody: <img src="image.gif" usemap="#mymap">
<map name="mymap">
    <area shape="rect" coords="0,0,1,1" href="#test1" >
    <area shape="circle" coords="0,1,1" href="#test2">
</map> , #0]
org.aim42.htmlsanitycheck.html.ImageMapParserSpec ‑ find all hrefs within map [nrOfHrefs: 1, mapName: mymap, htmlBody: <img src="image.gif" usemap="#mymap">
<map name="mymap">
    <area shape="rect" coords="0,0,1,1" href="#test1" >
</map> , hrefs: [#test1], #1]
…

♻️ This comment has been updated with latest results.

On GH pull requests the `git branch --show-current` does not return the branch name. In this case we use the SHA tag (only) for Docker tagging.

sonarqubecloud · 2025-10-12T13:26:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ascheman · 2025-10-12T15:04:01Z

Dummy to check for PR GH action build (works now)

ascheman and others added 26 commits October 2, 2025 11:09

#343 Make Baeldung exclusion a real regex

a24ee72

#369 Add shadow Jar for CLI (aka. Fat Jar)

c4a25d2

to prepare Docker build and GH action as it contains HSC and all dependencies.

#369 Add Docker build and GitHub action

c58fd0b

The primary goal is to provide a GitHub action. Additionally, we create and publish a multi-platform Docker image for usage in other scenarios (Standalone, GitLab CI, ...).

#369 Add integration test for Docker

de5d1b5

#369 Restrict Integration test for Docker

a7d11b0

Execute the Docker integration test only if Docker is available.

#369 Use Docker "latest" only on "main" branch

4103350

#369 Run Docker integration test on local image

690cef7

Will only be pushed on successful build and test by GitHub workflow.

#369 Skip Docker integration test on Windows

ba8fc1a

#369 Fix Docker build by pushing anyway

61d0fbd

Switching off Docker push leads to ERROR: failed to build: docker exporter does not currently support exporting manifest lists

#369 Add documentation for Docker run

f7ea603

#369 Enable fail-on-error for CLI

f658832

#369 Test GitHub action

a81384f

#369 Build Docker locally and fail on errors

1bb0eb3

The integration test must run with a local image first

#369 Separate Docker build(s)

7aacf0c

Locally we build for the respective platform and test with it. Then we build a multi-platform image and push that to the Registry.

#369 Enable additional Docker tags

ce446c3

Allow a push of the Docker image with additional tags to override or extend given images.

#369 Add housekeeping for timestamped images

19a95a3

We only need the timestamped Docker images for some time to enable testing of certain builds.

#369 Clean up untagged packages also

09784cf

and enable optional dry-run (default true)

Fix GH Caching key

a51b419

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Print some debug output to resolve dockerBuildLocal

55c0b30

#369 Use local Docker image

16edb58

The container image usually should be there due to a previous build step

#369 Use local Docker image with SHA tag

3d72f09

The container image must be there due to a previous build step

#369 Enable Docker push for SHA tag

5763a6b

Pushing a Docker image (even for testing purposes) requires respective permissions.

#369 Show local docker images on failure

6767aa7

#369 Pull after Docker push and show images

c71361a

We need to make sure the just build docker image is available for testing

#369 Fix setting of system property

b6478a0

#369 Fix printing of Docker images

a839d97

ascheman force-pushed the bugfix/369-gh-action-remote-fix branch 2 times, most recently from eeac6f1 to a0fec9b Compare October 12, 2025 10:33

#369 Use SHA for Docker tags if no branch detected

23e4907

On GH pull requests the `git branch --show-current` does not return the branch name. In this case we use the SHA tag (only) for Docker tagging.

ascheman force-pushed the bugfix/369-gh-action-remote-fix branch from a0fec9b to 23e4907 Compare October 12, 2025 11:42

ascheman closed this Oct 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Bugfix/369 gh action remote fix#425

Bugfix/369 gh action remote fix#425
ascheman wants to merge 27 commits into
developfrom
bugfix/369-gh-action-remote-fix

ascheman commented Oct 12, 2025

Uh oh!

github-actions Bot commented Oct 12, 2025 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Oct 12, 2025

Uh oh!

ascheman commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

ascheman commented Oct 12, 2025

Uh oh!

github-actions Bot commented Oct 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

sonarqubecloud Bot commented Oct 12, 2025

Quality Gate passed

Uh oh!

ascheman commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Oct 12, 2025 •

edited

Loading