54 implement knxip connector for building automation (#55)

* initial implementation knx connector for tokio

* initial implementation embassy knx connector

* format and rename demo

* update Makefile

* fix clippy errors and warnings

* update devcontainer CI workflow for improved efficiency

* persist watch receiver to avoid infinite subscription loop

* fix group adress parsing and refactor documentation for clarity

* remove conflicting memory.x from knx-pico to ensure correct STM32 memory layout

* implement outbound publishing for the tokio connector

* fix clippy

* implement outbound publishers for embassy

* update embassy

* fix clippy

* feat: Enhance KNX connector with ACK handling and timeout detection

- Added production status documentation in lib.rs.
- Refactored tokio_client.rs to implement pending ACK tracking for outbound telegrams.
- Introduced timeout detection for ACKs, with logging for timed-out sequences.
- Updated group address parsing in examples to handle various data formats.
- Added comprehensive integration tests for connection state management and frame building.
- Implemented unit tests for group address parsing and formatting.

* add knx-pico submodule

* update submodules

* Update Ethernet device type and configuration in KNX and MQTT demos

* fix: Update knx-pico dependency path to avoid version conflicts

* update knx-pico

* update knx pico

* reexport dpt from knx-pico crate

* use dpt en/decoding from knx-connector crate

* Refactor KNX connector to utilize knx-pico for type-safe group address handling and protocol parsing

* update embassy

* update README's

* Update examples/tokio-knx-connector-demo/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update examples/tokio-knx-connector-demo/README.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: lxsaah

.github/workflows/devcontainer.yml

@@ -4,18 +4,13 @@ on:
   push:
     branches: [ main, develop ]
     paths:
-      - '.devcontainer/Dockerfile'
-      - '.devcontainer/devcontainer.json'
+      - '.devcontainer/**'
       - '.github/workflows/devcontainer.yml'
   pull_request:
-    branches: [ main ]
+    branches: [ main, develop ]
     paths:
-      - '.devcontainer/Dockerfile'
-      - '.devcontainer/devcontainer.json'
+      - '.devcontainer/**'
       - '.github/workflows/devcontainer.yml'
-  schedule:
-    # Test weekly to catch upstream image changes
-    - cron: '0 6 * * 1'  # Every Monday at 6 AM UTC
   workflow_dispatch:
 
 env:
@@ -168,6 +163,19 @@ jobs:
         with:
           submodules: recursive
 
+      - name: Free up disk space
+        run: |
+          echo "Disk space before cleanup:"
+          df -h
+          sudo rm -rf /usr/share/dotnet
+          sudo rm -rf /usr/local/lib/android
+          sudo rm -rf /opt/ghc
+          sudo rm -rf /opt/hostedtoolcache/CodeQL
+          sudo docker image prune -af
+          sudo apt-get clean
+          echo "Disk space after cleanup:"
+          df -h
+
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 
@@ -186,6 +194,7 @@ jobs:
           image-ref: aimdb-devcontainer:scan
           format: 'sarif'
           output: 'trivy-results.sarif'
+          skip-dirs: '/usr/share/dotnet,/usr/local/lib/android'
 
       - name: Upload Trivy scan results to GitHub Security tab
         uses: github/codeql-action/upload-sarif@v3

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "_external/mountain-mqtt"]
 	path = _external/mountain-mqtt
 	url = https://github.com/aimdb-dev/mountain-mqtt.git
+[submodule "_external/knx-pico"]
+	path = _external/knx-pico
+	url = https://github.com/aimdb-dev/knx-pico.git

Cargo.lock

@@ -7,10 +7,13 @@ members = [
     "aimdb-tokio-adapter",
     "aimdb-sync",
     "aimdb-mqtt-connector",
+    "aimdb-knx-connector",
     "tools/aimdb-cli",
     "tools/aimdb-mcp",
     "examples/tokio-mqtt-connector-demo",
+    "examples/tokio-knx-connector-demo",
     "examples/embassy-mqtt-connector-demo",
+    "examples/embassy-knx-connector-demo",
     "examples/sync-api-demo",
     "examples/remote-access-demo",
 ]

Cargo.toml

@@ -56,6 +56,8 @@ build:
 	cargo build --package aimdb-cli
 	@printf "$(YELLOW)  → Building MCP server$(NC)\n"
 	cargo build --package aimdb-mcp
+	@printf "$(YELLOW)  → Building KNX connector$(NC)\n"
+	cargo build --package aimdb-knx-connector --features "std,tokio-runtime"
 
 test:
 	@printf "$(GREEN)Running all tests (valid combinations)...$(NC)\n"
@@ -73,10 +75,12 @@ test:
 	cargo test --package aimdb-cli
 	@printf "$(YELLOW)  → Testing MCP server$(NC)\n"
 	cargo test --package aimdb-mcp
+	@printf "$(YELLOW)  → Testing KNX connector$(NC)\n"
+	cargo test --package aimdb-knx-connector --features "std,tokio-runtime"
 
 fmt:
 	@printf "$(GREEN)Formatting code (workspace members only)...$(NC)\n"
-	@for pkg in aimdb-executor aimdb-core aimdb-client aimdb-embassy-adapter aimdb-tokio-adapter aimdb-sync aimdb-mqtt-connector aimdb-cli aimdb-mcp sync-api-demo tokio-mqtt-connector-demo embassy-mqtt-connector-demo; do \
+	@for pkg in aimdb-executor aimdb-core aimdb-client aimdb-embassy-adapter aimdb-tokio-adapter aimdb-sync aimdb-mqtt-connector aimdb-knx-connector aimdb-cli aimdb-mcp sync-api-demo tokio-mqtt-connector-demo embassy-mqtt-connector-demo tokio-knx-connector-demo embassy-knx-connector-demo; do \
 		printf "$(YELLOW)  → Formatting $$pkg$(NC)\n"; \
 		cargo fmt -p $$pkg 2>/dev/null || true; \
 	done
@@ -85,7 +89,7 @@ fmt:
 fmt-check:
 	@printf "$(GREEN)Checking code formatting (workspace members only)...$(NC)\n"
 	@FAILED=0; \
-	for pkg in aimdb-executor aimdb-core aimdb-client aimdb-embassy-adapter aimdb-tokio-adapter aimdb-sync aimdb-mqtt-connector aimdb-cli aimdb-mcp sync-api-demo tokio-mqtt-connector-demo embassy-mqtt-connector-demo; do \
+	for pkg in aimdb-executor aimdb-core aimdb-client aimdb-embassy-adapter aimdb-tokio-adapter aimdb-sync aimdb-mqtt-connector aimdb-knx-connector aimdb-cli aimdb-mcp sync-api-demo tokio-mqtt-connector-demo embassy-mqtt-connector-demo tokio-knx-connector-demo embassy-knx-connector-demo; do \
 		printf "$(YELLOW)  → Checking $$pkg$(NC)\n"; \
 		if ! cargo fmt -p $$pkg -- --check 2>&1; then \
 			printf "$(RED)❌ Formatting check failed for $$pkg$(NC)\n"; \
@@ -118,6 +122,10 @@ clippy:
 	cargo clippy --package aimdb-cli --all-targets -- -D warnings
 	@printf "$(YELLOW)  → Clippy on MCP server$(NC)\n"
 	cargo clippy --package aimdb-mcp --all-targets -- -D warnings
+	@printf "$(YELLOW)  → Clippy on KNX connector (std)$(NC)\n"
+	cargo clippy --package aimdb-knx-connector --features "std,tokio-runtime" --all-targets -- -D warnings
+	@printf "$(YELLOW)  → Clippy on KNX connector (embassy)$(NC)\n"
+	cargo clippy --package aimdb-knx-connector --target thumbv7em-none-eabihf --no-default-features --features "embassy-runtime" -- -D warnings
 
 doc:
 	@printf "$(GREEN)Generating dual-platform documentation...$(NC)\n"
@@ -129,13 +137,15 @@ doc:
 	cargo doc --package aimdb-tokio-adapter --features "tokio-runtime,tracing,metrics" --no-deps
 	cargo doc --package aimdb-sync --no-deps
 	cargo doc --package aimdb-mqtt-connector --features "std,tokio-runtime" --no-deps
+	cargo doc --package aimdb-knx-connector --features "std,tokio-runtime" --no-deps
 	cargo doc --package aimdb-cli --no-deps
 	cargo doc --package aimdb-mcp --no-deps
 	@cp -r target/doc/* target/doc-final/cloud/
 	@printf "$(YELLOW)  → Building embedded documentation$(NC)\n"
 	cargo doc --package aimdb-core --no-default-features --no-deps
 	cargo doc --package aimdb-embassy-adapter --features "embassy-runtime" --no-deps
 	cargo doc --package aimdb-mqtt-connector --no-default-features --features "embassy-runtime" --no-deps
+	cargo doc --package aimdb-knx-connector --no-default-features --features "embassy-runtime" --no-deps
 	@cp -r target/doc/* target/doc-final/embedded/
 	@printf "$(YELLOW)  → Creating main index page$(NC)\n"
 	@cp docs/index.html target/doc-final/index.html
@@ -158,6 +168,8 @@ test-embedded:
 	cargo check --package aimdb-embassy-adapter --target thumbv7em-none-eabihf --no-default-features --features "embassy-runtime,embassy-net-support"
 	@printf "$(YELLOW)  → Checking aimdb-mqtt-connector (Embassy) on thumbv7em-none-eabihf target$(NC)\n"
 	cargo check --package aimdb-mqtt-connector --target thumbv7em-none-eabihf --no-default-features --features "embassy-runtime"
+	@printf "$(YELLOW)  → Checking aimdb-knx-connector (Embassy) on thumbv7em-none-eabihf target$(NC)\n"
+	cargo check --package aimdb-knx-connector --target thumbv7em-none-eabihf --no-default-features --features "embassy-runtime"
 
 ## Example projects
 examples:
@@ -168,6 +180,10 @@ examples:
 	cargo build --package tokio-mqtt-connector-demo
 	@printf "$(YELLOW)  → Building embassy-mqtt-connector-demo (embedded, embassy runtime)$(NC)\n"
 	cargo build --package embassy-mqtt-connector-demo --target thumbv7em-none-eabihf
+	@printf "$(YELLOW)  → Building tokio-knx-connector-demo (native, tokio runtime)$(NC)\n"
+	cargo build --package tokio-knx-connector-demo
+	@printf "$(YELLOW)  → Building embassy-knx-connector-demo (embedded, embassy runtime)$(NC)\n"
+	cargo build --package embassy-knx-connector-demo --target thumbv7em-none-eabihf
 	@printf "$(GREEN)All examples built successfully!$(NC)\n"
 
 ## Security & Quality commands

Makefile

@@ -195,6 +195,7 @@ impl<
         // Clone the Arc for the reader
         EmbassyBufferReader {
             buffer: Arc::clone(&self.inner),
+            watch_receiver: None, // Will be initialized on first recv() for Watch buffers
         }
     }
 }
@@ -264,8 +265,8 @@ impl<
 
 /// Reader for Embassy buffers
 ///
-/// Holds an Arc reference to the buffer. Each recv() call creates a temporary
-/// subscription to read one value.
+/// Holds persistent subscription state for each buffer type.
+/// For Watch buffers, stores a persistent Receiver to track which value has been seen.
 pub struct EmbassyBufferReader<
     T: Clone + Send + 'static,
     const CAP: usize,
@@ -274,6 +275,9 @@ pub struct EmbassyBufferReader<
     const WATCH_N: usize,
 > {
     buffer: Arc<EmbassyBufferInner<T, CAP, SUBS, PUBS, WATCH_N>>,
+    /// Persistent Watch receiver. The 'static lifetime is safe because the Arc keeps the Watch alive.
+    watch_receiver:
+        Option<embassy_sync::watch::Receiver<'static, CriticalSectionRawMutex, T, WATCH_N>>,
 }
 
 impl<
@@ -289,8 +293,6 @@ impl<
     ) -> core::pin::Pin<Box<dyn core::future::Future<Output = Result<T, DbError>> + Send + '_>>
     {
         Box::pin(async move {
-            // Create a temporary subscription for this recv() call
-            // This works because the Arc keeps the buffer alive
             match &*self.buffer {
                 EmbassyBufferInner::SpmcRing(channel) => match channel.subscriber() {
                     Ok(mut sub) => match sub.next_message().await {
@@ -302,10 +304,32 @@ impl<
                     },
                     Err(_) => Err(DbError::BufferClosed { _buffer_name: () }),
                 },
-                EmbassyBufferInner::Watch(watch) => match watch.receiver() {
-                    Some(mut rx) => Ok(rx.changed().await),
-                    None => Err(DbError::BufferClosed { _buffer_name: () }),
-                },
+                EmbassyBufferInner::Watch(watch) => {
+                    // Watch requires a persistent receiver to track seen values.
+                    // Creating a new receiver each time causes infinite loops (always returns current value).
+                    if self.watch_receiver.is_none() {
+                        // SAFETY: The Arc in self.buffer keeps the Watch alive for this reader's lifetime.
+                        // We extend the lifetime to 'static to store the receiver, which is safe because
+                        // the receiver is just (&Watch, u64 counter) and will be dropped with the reader.
+                        let watch_static: &'static embassy_sync::watch::Watch<
+                            CriticalSectionRawMutex,
+                            T,
+                            WATCH_N,
+                        > = unsafe { &*(watch as *const _) };
+
+                        self.watch_receiver = watch_static.receiver();
+                        if self.watch_receiver.is_none() {
+                            return Err(DbError::BufferClosed { _buffer_name: () });
+                        }
+                    }
+
+                    // Use the persistent receiver to detect changes
+                    if let Some(ref mut rx) = self.watch_receiver {
+                        Ok(rx.changed().await)
+                    } else {
+                        Err(DbError::BufferClosed { _buffer_name: () })
+                    }
+                }
                 EmbassyBufferInner::Mailbox(channel) => {
                     let rx = channel.receiver();
                     Ok(rx.receive().await)