feat(tcp-connector): add Embassy TCP listener pool#171
Merged
Conversation
Implement the Embassy TCP server as an explicit N-socket pool backed by caller-owned RX/TX buffers and make the Embassy TCP dialer reusable across disconnects/redials. Also tighten `tcp://` endpoint validation for IPv6 targets, clean up TCP connector feature dependencies and include the tokio KNX demo in fmt-check coverage.
lxsaah
approved these changes
Jul 9, 2026
lxsaah
left a comment
lxsaah
left a comment
Contributor
There was a problem hiding this comment.
looks good to me!
Thanks a lot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TcpServer::<N>::with_buffers(...)for Embassy TCP servers, using an explicit N-socket RX/TX buffer pool.N >= 2can accept concurrent inbound TCP clients.tcp://endpoint validation, including bracketed IPv6 support and rejection of naked IPv6 targets.aimdb-tcp-connectorfeature dependencies and includetokio-knx-connector-demoinfmt-check.Related Issue
Checklist
make check).