#94 — Minimal example: hello-mailbox#98
Conversation
lxsaah
left a comment
There was a problem hiding this comment.
Great first contribution! Works correctly, all checks pass on the example itself. Verified locally that make check and make all are both green once the Makefile is wired up for the new crate.
Left inline suggestions you can apply with one click each. They cover:
- Example polish — broken README link, unused deps, minor wording.
- Cargo.toml — workspace member formatting + description convention.
One thing I couldn't add as inline suggestions: the Makefile isn't part of your PR diff, so GitHub blocks suggestion comments on it. Could you add hello-mailbox to the Makefile manually? Three spots:
- The
make fmtfor-loop on line ~122: appendhello-mailboxto the package list, right before; do \ - The
make fmt-checkfor-loop on line ~131: same - The
examplestarget around line 277: add a new build step right before the success printf:
@printf "$(YELLOW) → Building hello-mailbox (minimal Mailbox buffer demo)$(NC)\n"
cargo build --package hello-mailboxOnce those Makefile changes plus the inline suggestions are in, we're good to merge.
We're planning to file a follow-up issue for an async sibling (hello-mailbox-async) as a separate crate, so your sync version stays exactly as it is. If you'd like to take the async version next, let me know and I'll assign it to you.
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
Co-authored-by: sounds.like.lx <147444674+lxsaah@users.noreply.github.com>
|
Hi, Done! Applied all the inline suggestions and updated the Makefile |
|
I'd love to take the async version, but I want to make sure I understand async Rust better first. I'll follow up once I feel ready. |
Sure, take your time. I'll file the issue and keep it in the backlog. Just take it as soon as you feel ready. |
|
thanks @ggmaldo, this is the first community contribution to AimDB 🎉 |
|
No problem, Thanks you, I'll try to help this proyect the best as i can |
Description
Created the MailBox example at examples/hello-mailbox
Related Issue
hello-mailboxHow to test
Expected output