Merge branch 'master' into dynamic-ports-finish

Author: rodrigobnogueira

CHANGES/12170.misc.rst

@@ -0,0 +1 @@
+Fixed race condition in ``test_data_file`` on Python 3.14 free-threaded builds -- by :user:`rodrigobnogueira`.

aiohttp/formdata.py

@@ -1,4 +1,5 @@
 import io
+from collections import deque
 from collections.abc import Iterable
 from typing import Any
 from urllib.parse import urlencode
@@ -81,10 +82,10 @@ def add_field(
         self._fields.append((type_options, headers, value))
 
     def add_fields(self, *fields: Any) -> None:
-        to_add = list(fields)
+        to_add: deque[Any] = deque(fields)
 
         while to_add:
-            rec = to_add.pop(0)
+            rec = to_add.popleft()
 
             if isinstance(rec, io.IOBase):
                 k = guess_filename(rec, "unknown")

docs/web_reference.rst

@@ -2902,7 +2902,9 @@ application on specific TCP or Unix socket, e.g.::
 
    :param str host: HOST to listen on, all interfaces if ``None`` (default).
 
-   :param int port: PORT to listed on, ``8080`` if ``None`` (default).
+   :param int port: PORT to listen on, ``8080`` if ``None`` (default).
+                    Use ``0`` to let the OS assign a free ephemeral port
+                    (see :attr:`port`).
 
    :param float shutdown_timeout: a timeout used for both waiting on pending
                                   tasks before application shutdown and for
@@ -2935,20 +2937,6 @@ application on specific TCP or Unix socket, e.g.::
       Read-only. The actual port number the server is bound to, only
       guaranteed to be correct after the site has been started.
 
-      To bind to a dynamic port, pass ``0`` as the port number. The OS
-      will assign a free port which can then be retrieved from this
-      attribute::
-
-          app = web.Application()
-          runner = web.AppRunner(app)
-          await runner.setup()
-          site = web.TCPSite(runner, 'localhost', 0)
-          await site.start()
-
-          print(f"Server started on port {site.port}")
-          while True:
-              await asyncio.sleep(3600)  # sleep forever
-
 
 .. class:: UnixSite(runner, path, *, \
                    shutdown_timeout=60.0, ssl_context=None, \

tests/test_client_request.py

@@ -1352,7 +1352,18 @@ async def test_data_file(
         assert isinstance(req.body, payload.BufferedReaderPayload)
         assert req.headers["TRANSFER-ENCODING"] == "chunked"
 
-        resp = await req._send(conn)
+        original_write_bytes = req._write_bytes
+
+        async def _mock_write_bytes(
+            writer: AbstractStreamWriter, conn: mock.Mock, content_length: int | None
+        ) -> None:
+            # Ensure the task is scheduled so _writer isn't None
+            await asyncio.sleep(0)
+            await original_write_bytes(writer, conn, content_length)
+
+        with mock.patch.object(req, "_write_bytes", _mock_write_bytes):
+            resp = await req._send(conn)
+
         assert asyncio.isfuture(req._writer)
         await resp.wait_for_close()