Make AppRunner's configuration options available in run_app()#11633
Make AppRunner's configuration options available in run_app()#11633Dreamsorcerer merged 8 commits intoaio-libs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11633 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 127 127
Lines 43448 43449 +1
Branches 2326 2326
=======================================
+ Hits 42903 42904 +1
Misses 389 389
Partials 156 156
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #11633 will not alter performanceComparing Summary
Footnotes |
Backport to 3.13: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b1bd65d on top of patchback/backports/3.13/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633 Backporting merged PR #11633 into master
🤖 @patchback |
Backport to 3.14: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b1bd65d on top of patchback/backports/3.14/b1bd65dbd191b318325c4b87d626bb5d7967cda7/pr-11633 Backporting merged PR #11633 into master
🤖 @patchback |
What do these changes do?
Some configuration flags are only available in
AppRunner. This pr makes them also configurable inrun_app().Are there changes in behavior for the user?
Users can now set more configuration options in
run_app()to serve aiohttp web application without creating customAppRunnerinstances.Is it a substantial burden for the maintainers to support this?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGES/folder