Skip to content

add xfail test for issue 11632#11651

Merged
Dreamsorcerer merged 4 commits intoaio-libs:masterfrom
thehesiod-forks:thehesiod/issue-11632
Oct 15, 2025
Merged

add xfail test for issue 11632#11651
Dreamsorcerer merged 4 commits intoaio-libs:masterfrom
thehesiod-forks:thehesiod/issue-11632

Conversation

@thehesiod
Copy link
Copy Markdown
Contributor

What do these changes do?

Are there changes in behavior for the user?

Is it a substantial burden for the maintainers to support this?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.74%. Comparing base (b1bd65d) to head (8f499db).
⚠️ Report is 284 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_cookie_helpers.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11651      +/-   ##
==========================================
+ Coverage   98.72%   98.74%   +0.01%     
==========================================
  Files         127      127              
  Lines       43449    43473      +24     
  Branches     2326     2327       +1     
==========================================
+ Hits        42896    42927      +31     
+ Misses        395      390       -5     
+ Partials      158      156       -2     
Flag Coverage Δ
CI-GHA 98.62% <83.33%> (+0.01%) ⬆️
OS-Linux 98.36% <83.33%> (+0.01%) ⬆️
OS-Windows 96.68% <83.33%> (+0.10%) ⬆️
OS-macOS 97.58% <83.33%> (+0.12%) ⬆️
Py-3.10.11 97.14% <83.33%> (-0.01%) ⬇️
Py-3.10.18 97.64% <83.33%> (-0.01%) ⬇️
Py-3.11.13 97.84% <83.33%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <83.33%> (-0.01%) ⬇️
Py-3.12.10 97.45% <83.33%> (+0.27%) ⬆️
Py-3.12.11 97.94% <83.33%> (-0.01%) ⬇️
Py-3.13.7 98.20% <83.33%> (+0.67%) ⬆️
Py-3.14.0 98.15% <83.33%> (+0.25%) ⬆️
Py-3.14.0t 97.22% <83.33%> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 80.98% <83.33%> (?)
VM-macos 97.58% <83.33%> (+0.12%) ⬆️
VM-ubuntu 98.36% <83.33%> (+0.01%) ⬆️
VM-windows 96.68% <83.33%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Oct 14, 2025

CodSpeed Performance Report

Merging #11651 will not alter performance

Comparing thehesiod-forks:thehesiod/issue-11632 (8f499db) with master (d261f8a)1

Summary

✅ 59 untouched

Footnotes

  1. No successful run was found on master (65faf6e) during the generation of this report, so d261f8a was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Comment thread tests/test_cookie_helpers.py Outdated
Comment thread tests/test_cookie_helpers.py Outdated
Comment thread tests/test_cookie_helpers.py Outdated
@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note labels Oct 14, 2025
thehesiod and others added 3 commits October 14, 2025 17:42
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
Co-authored-by: Sam Bull <aa6bs0@sambull.org>
@Dreamsorcerer Dreamsorcerer merged commit 398329f into aio-libs:master Oct 15, 2025
40 of 41 checks passed
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Oct 15, 2025

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/398329f6ec6237cb0f29149863485cccec65258a/pr-11651

Backported as #11658

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Oct 15, 2025
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Oct 15, 2025

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/398329f6ec6237cb0f29149863485cccec65258a/pr-11651

Backported as #11659

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Oct 15, 2025
Dreamsorcerer pushed a commit that referenced this pull request Oct 15, 2025
…11659)

**This is a backport of PR #11651 as merged into master
(398329f).**

Co-authored-by: Alexander Mohr <thehesiod@users.noreply.github.com>
Dreamsorcerer pushed a commit that referenced this pull request Oct 15, 2025
…11658)

**This is a backport of PR #11651 as merged into master
(398329f).**

Co-authored-by: Alexander Mohr <thehesiod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants