Skip to content

add xfail test for https://github.com/aio-libs/aiohttp/issues/11665#11666

Merged
Dreamsorcerer merged 8 commits intoaio-libs:masterfrom
alastairvox:master
Oct 16, 2025
Merged

add xfail test for https://github.com/aio-libs/aiohttp/issues/11665#11666
Dreamsorcerer merged 8 commits intoaio-libs:masterfrom
alastairvox:master

Conversation

@alastairvox
Copy link
Copy Markdown
Contributor

@alastairvox alastairvox commented Oct 16, 2025

What do these changes do?

This is only a test for the linked issue: #11665

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

Related issue number

#11665

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@alastairvox alastairvox requested a review from asvetlov as a code owner October 16, 2025 05:48
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.74%. Comparing base (149a810) to head (8b6cfc4).
⚠️ Report is 277 commits behind head on master.

Files with missing lines Patch % Lines
tests/test_web_urldispatcher.py 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11666      +/-   ##
==========================================
- Coverage   98.74%   98.74%   -0.01%     
==========================================
  Files         127      127              
  Lines       43535    43550      +15     
  Branches     2327     2327              
==========================================
+ Hits        42989    43002      +13     
- Misses        390      392       +2     
  Partials      156      156              
Flag Coverage Δ
CI-GHA 98.62% <86.66%> (-0.01%) ⬇️
OS-Linux 98.36% <86.66%> (-0.01%) ⬇️
OS-Windows 96.68% <86.66%> (-0.01%) ⬇️
OS-macOS 97.58% <86.66%> (-0.01%) ⬇️
Py-3.10.11 97.14% <80.00%> (-0.01%) ⬇️
Py-3.10.18 97.64% <80.00%> (-0.02%) ⬇️
Py-3.11.13 97.84% <80.00%> (+<0.01%) ⬆️
Py-3.11.9 97.34% <80.00%> (-0.01%) ⬇️
Py-3.12.10 97.45% <80.00%> (-0.01%) ⬇️
Py-3.12.11 97.94% <80.00%> (-0.01%) ⬇️
Py-3.13.7 98.19% <80.00%> (-0.02%) ⬇️
Py-3.14.0 98.15% <86.66%> (-0.01%) ⬇️
Py-3.14.0t 97.21% <86.66%> (-0.02%) ⬇️
Py-pypy3.10.16-7.3.19 88.40% <80.00%> (-5.43%) ⬇️
VM-macos 97.58% <86.66%> (-0.01%) ⬇️
VM-ubuntu 98.36% <86.66%> (-0.01%) ⬇️
VM-windows 96.68% <86.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread tests/test_web_urldispatcher.py
Comment thread tests/test_web_urldispatcher.py
@webknjaz webknjaz added bot:chronographer:skip This PR does not need to include a change note backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Oct 16, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #11666 will not alter performance

Comparing alastairvox:master (8b6cfc4) with master (149a810)1

Summary

✅ 59 untouched

Footnotes

  1. No successful run was found on master (4234f7f) during the generation of this report, so 149a810 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) October 16, 2025 14:28
@Dreamsorcerer Dreamsorcerer merged commit 1590c86 into aio-libs:master Oct 16, 2025
39 of 40 checks passed
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Oct 16, 2025

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/1590c86059f20d7955e523de139d35f88e87eb23/pr-11666

Backported as #11671

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Oct 16, 2025

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/1590c86059f20d7955e523de139d35f88e87eb23/pr-11666

Backported as #11672

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Oct 16, 2025
(cherry picked from commit 1590c86)
Dreamsorcerer pushed a commit that referenced this pull request Oct 16, 2025
**This is a backport of PR #11666 as merged into master
(1590c86).**

Co-authored-by: Alastair <22815637+alastairvox@users.noreply.github.com>
Dreamsorcerer pushed a commit that referenced this pull request Oct 16, 2025
**This is a backport of PR #11666 as merged into master
(1590c86).**

Co-authored-by: Alastair <22815637+alastairvox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants