Skip to content

Fix domain matching being lower priority than path matching#11673

Merged
Dreamsorcerer merged 4 commits intomasterfrom
Dreamsorcerer-patch-5
Oct 16, 2025
Merged

Fix domain matching being lower priority than path matching#11673
Dreamsorcerer merged 4 commits intomasterfrom
Dreamsorcerer-patch-5

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

@Dreamsorcerer Dreamsorcerer commented Oct 16, 2025 •
edited
Loading

Fixes #11665.

@Dreamsorcerer Dreamsorcerer added backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot labels Oct 16, 2025
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Oct 16, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Oct 16, 2025

CodSpeed Performance Report

Merging #11673 will not alter performance

Comparing Dreamsorcerer-patch-5 (a7bb678) with master (1590c86)

Summary

✅ 59 untouched

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 16, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.74%. Comparing base (1590c86) to head (a7bb678).
⚠️ Report is 274 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #11673      +/-   ##
==========================================
+ Coverage   98.73%   98.74%   +0.01%     
==========================================
  Files         127      127              
  Lines       43550    43549       -1     
  Branches     2327     2327              
==========================================
+ Hits        42999    43003       +4     
+ Misses        395      390       -5     
  Partials      156      156
Flag Coverage Δ
CI-GHA 98.63% <100.00%> (+0.01%) ⬆️
OS-Linux 98.36% <100.00%> (+0.01%) ⬆️
OS-Windows 96.69% <100.00%> (+0.01%) ⬆️
OS-macOS 97.58% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.15% <100.00%> (+<0.01%) ⬆️
Py-3.10.18 97.65% <100.00%> (+<0.01%) ⬆️
Py-3.11.13 97.84% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.35% <100.00%> (+<0.01%) ⬆️
Py-3.12.10 97.45% <100.00%> (+<0.01%) ⬆️
Py-3.12.11 97.95% <100.00%> (+0.01%) ⬆️
Py-3.13.7 98.20% <100.00%> (+<0.01%) ⬆️
Py-3.14.0 98.15% <100.00%> (+<0.01%) ⬆️
Py-3.14.0t 97.22% <100.00%> (+<0.01%) ⬆️
Py-pypy3.10.16-7.3.19 88.56% <100.00%> (+0.05%) ⬆️
VM-macos 97.58% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 98.36% <100.00%> (+0.01%) ⬆️
VM-windows 96.69% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit e8c5252 into master Oct 16, 2025
42 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-5 branch October 16, 2025 16:50
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Oct 16, 2025 •
edited
Loading

Backport to 3.13: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.13/e8c5252cb28ce1db0232fc5fc66909791313c08b/pr-11673

Backported as #11675

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Oct 16, 2025
@Dreamsorcerer @patchback
Fix domain matching being lower priority than path matching (#11673)
9f91ce3 
(cherry picked from commit e8c5252)
@patchback patchback Bot mentioned this pull request Oct 16, 2025
Merged
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Oct 16, 2025 •
edited
Loading

Backport to 3.14: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.14/e8c5252cb28ce1db0232fc5fc66909791313c08b/pr-11673

Backported as #11676

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback Bot pushed a commit that referenced this pull request Oct 16, 2025
@Dreamsorcerer @patchback
Fix domain matching being lower priority than path matching (#11673)
fd20200 
(cherry picked from commit e8c5252)
@patchback patchback Bot mentioned this pull request Oct 16, 2025
Merged
Dreamsorcerer added a commit that referenced this pull request Oct 16, 2025
@patchback @Dreamsorcerer
[PR #11673/e8c5252c backport][3.14] Fix domain matching being lower p…
fb69cf0 
…riority than path matching (#11676)

**This is a backport of PR #11673 as merged into master
(e8c5252).**

Co-authored-by: Sam Bull <git@sambull.org>
Dreamsorcerer added a commit that referenced this pull request Oct 16, 2025
@patchback @Dreamsorcerer
[PR #11673/e8c5252c backport][3.13] Fix domain matching being lower p…
e618dcb 
…riority than path matching (#11675)

**This is a backport of PR #11673 as merged into master
(e8c5252).**

Co-authored-by: Sam Bull <git@sambull.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

backport-3.13 Trigger automatic backporting to the 3.13 release branch by Patchback robot backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Subapp routing using add_domain() does not route as expected.

2 participants

@Dreamsorcerer @bdraco