Skip to content

fix(tests): use .invalid TLD for unresolvable DNS test #12416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dreamsorcerer merged 3 commits into from
May 4, 2026
+1 −1
Merged

fix(tests): use .invalid TLD for unresolvable DNS test #12416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b78ee42
fix(tests): use .invalid TLD for unresolvable DNS test
Apr 22, 2026
e127668
fix(tests): address review on PR #12416
BojunChai Apr 30, 2026
ac5b6d1
Delete CHANGES/11293.misc.rst
Dreamsorcerer May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_client_functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3754,7 +3754,7 @@ async def handler(request: web.Request) -> NoReturn:

async def test_aiohttp_request_ctx_manager_not_found() -> None:
with pytest.raises(aiohttp.ClientConnectionError):
async with aiohttp.request("GET", "http://wrong-dns-name.com"):
async with aiohttp.request("GET", "http://wrong-dns-name.invalid"):
assert False


Expand Down
Loading