Skip to content

Reduce client timeout test runtime#12673

Open
nightcityblade wants to merge 2 commits into
aio-libs:masterfrom
nightcityblade:fix/issue-9705
Open

Reduce client timeout test runtime#12673
nightcityblade wants to merge 2 commits into
aio-libs:masterfrom
nightcityblade:fix/issue-9705

Conversation

@nightcityblade
Copy link
Copy Markdown
Contributor

What do these changes do?

Reduce the runtime of test_read_timeout_between_chunks by shortening the artificial per-chunk delay while keeping it below the configured per-read timeout.

Are there changes in behavior for the user?

No. This only changes test timing.

Is it a substantial burden for the maintainers to support this?

No. The test still covers the same per-read timeout behavior with shorter waits, so it should reduce CI time without adding maintenance overhead.

Related issue number

Refs #9705.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is .
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.95%. Comparing base (1c472b5) to head (29ad1f3).
⚠️ Report is 387 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12673      +/-   ##
==========================================
+ Coverage   98.77%   98.95%   +0.17%     
==========================================
  Files         128      131       +3     
  Lines       44890    46688    +1798     
  Branches     2383     2421      +38     
==========================================
+ Hits        44340    46200    +1860     
+ Misses        390      366      -24     
+ Partials      160      122      -38     
Flag Coverage Δ
Autobahn 22.42% <0.00%> (?)
CI-GHA 98.92% <100.00%> (+0.29%) ⬆️
OS-Linux 98.67% <100.00%> (+0.30%) ⬆️
OS-Windows 97.03% <100.00%> (+0.32%) ⬆️
OS-macOS 97.93% <100.00%> (+0.32%) ⬆️
Py-3.10 98.15% <100.00%> (?)
Py-3.10.11 ?
Py-3.10.19 ?
Py-3.11 98.41% <100.00%> (?)
Py-3.11.14 ?
Py-3.11.9 ?
Py-3.12 98.50% <100.00%> (?)
Py-3.12.10 ?
Py-3.12.12 ?
Py-3.13 98.47% <100.00%> (?)
Py-3.13.12 ?
Py-3.14 98.50% <100.00%> (?)
Py-3.14.3 ?
Py-3.14.3t ?
Py-3.14t 97.55% <100.00%> (?)
Py-pypy-3.11 97.42% <100.00%> (?)
Py-pypy3.11.13-7.3.20 ?
VM-macos 97.93% <100.00%> (+0.32%) ⬆️
VM-ubuntu 98.67% <100.00%> (+0.30%) ⬆️
VM-windows 97.03% <100.00%> (+0.32%) ⬆️
cython-coverage 37.94% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2026

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 72 skipped benchmarks1


Comparing nightcityblade:fix/issue-9705 (29ad1f3) with master (a0a03ca)

Open in CodSpeed

Footnotes

  1. 72 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

resp = aiohttp.web.StreamResponse()
await resp.prepare(request)
# write data 4 times, with pauses. Total time 2 seconds.
# write data 4 times, with pauses. Total time 0.2 seconds.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was longer than the timeout before...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants