Reduce client timeout test runtime#12673
Conversation
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #12673 +/- ##
==========================================
+ Coverage 98.77% 98.95% +0.17%
==========================================
Files 128 131 +3
Lines 44890 46688 +1798
Branches 2383 2421 +38
==========================================
+ Hits 44340 46200 +1860
+ Misses 390 366 -24
+ Partials 160 122 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merging this PR will not alter performance
Comparing Footnotes
|
| resp = aiohttp.web.StreamResponse() | ||
| await resp.prepare(request) | ||
| # write data 4 times, with pauses. Total time 2 seconds. | ||
| # write data 4 times, with pauses. Total time 0.2 seconds. |
There was a problem hiding this comment.
This was longer than the timeout before...
What do these changes do?
Reduce the runtime of
test_read_timeout_between_chunksby shortening the artificial per-chunk delay while keeping it below the configured per-read timeout.Are there changes in behavior for the user?
No. This only changes test timing.
Is it a substantial burden for the maintainers to support this?
No. The test still covers the same per-read timeout behavior with shorter waits, so it should reduce CI time without adding maintenance overhead.
Related issue number
Refs #9705.
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.