Skip to content

Commit aef89a2

Browse files
committed
ci: migrate MyPy coverage from Codecov to Coveralls
Move type coverage reporting to Coveralls per aio-libs/multidict#1231. Updates workflows to use coverallsapp/github-action, removes codecov-token secret, and drops typing config from .codecov.yml.
1 parent 2392a08 commit aef89a2

4 files changed

Lines changed: 14 additions & 18 deletions

File tree

.codecov.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
codecov:
44
notify:
5-
after_n_builds: 20 # The number of test matrix+lint jobs uploading coverage
5+
after_n_builds: 19 # The number of test matrix+lint jobs uploading coverage
66
wait_for_ci: false
77

88
require_ci_to_pass: false
@@ -40,9 +40,5 @@ coverage:
4040
paths:
4141
- tests/
4242
target: 100%
43-
typing:
44-
flags:
45-
- MyPy
46-
target: 100%
4743

4844
...

.github/workflows/ci-cd.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ jobs:
123123

124124
lint:
125125
uses: ./.github/workflows/reusable-linters.yml
126-
secrets:
127-
codecov-token: ${{ secrets.CODECOV_TOKEN }}
128126

129127
build-wheels-for-tested-arches:
130128
name: >- # ${{ '' } is a hack to nest jobs under the same sidebar category

.github/workflows/reusable-linters.yml

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@ name: Linters
44

55
on:
66
workflow_call:
7-
secrets:
8-
codecov-token:
9-
description: Mandatory token for uploading to Codecov
10-
required: true
117

128
env:
139
COLOR: >- # Supposedly, pytest or coveragepy use this
@@ -66,16 +62,16 @@ jobs:
6662
- name: Run linters
6763
run: |
6864
make lint
69-
- name: Send coverage data to Codecov
70-
uses: codecov/codecov-action@v6
65+
- name: Send coverage data to Coveralls
66+
uses: coverallsapp/github-action@v2
7167
with:
72-
token: ${{ secrets.codecov-token }}
68+
debug: ${{ runner.debug == '1' && true || false }}
69+
fail-on-error: ${{ runner.debug == '1' && false || true }}
7370
files: >-
7471
.tox/.tmp/.mypy/python-3.11/cobertura.xml
75-
flags: >-
76-
CI-GHA,
77-
MyPy
78-
fail_ci_if_error: true
72+
flag-name: MyPy
73+
format: cobertura
74+
measure: ${{ runner.debug == '1' && true || false }}
7975
- name: Install spell checker
8076
run: |
8177
pip install -r requirements/doc.txt

CHANGES/756.contrib.rst

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
The type preciseness coverage report generated by `MyPy
2+
<https://mypy-lang.org>`__ is now uploaded to `Coveralls
3+
<https://coveralls.io/github/aio-libs/frozenlist>`__ and
4+
will not be included in the `Codecov views
5+
<https://app.codecov.io/gh/aio-libs/frozenlist>`__ going forward
6+
-- by :user:`webknjaz`.

0 commit comments

Comments
 (0)