Migrate MyPy coverage from Codecov to Coveralls - #758
Conversation
|
@aiolibsbot Use the pr template for aiolibs |
|
@aiolibsbot Rr |
PR Review — Move reporting MyPy type preciseness to CoverallsMechanically a clean port of aio-libs/multidict#1231: Codecov action swapped for Coveralls, 🟡 Important1. 100% MyPy coverage gate is dropped with no Coveralls equivalent (`.codecov.yml`, L40-44)The removed Confirm one of the following: (a) the 100% gate has already been recreated on the Coveralls side (out-of-band project config), (b) it is intentional to drop the hard gate and rely on review-time inspection of the dashboard, or (c) a follow-up PR will add the gate. Without that, a future MyPy regression will silently produce a dashboard delta instead of failing CI. 🟢 Suggestions1. `CI-GHA` flag is dropped in the migration (`.github/workflows/reusable-linters.yml`, L65-74)The previous Codecov step uploaded under two flags: 2. Verify `after_n_builds: 19` matches the actual upload count (`.codecov.yml`, L5)The comment on this line says "The number of test matrix+lint jobs uploading coverage". Decrementing 20→19 is consistent with removing exactly one Codecov upload (the MyPy/typing one from the lint job). Worth a quick sanity check that no other Codecov upload step elsewhere in the workflows was also removed or added in flight — if Codecov waits for 19 uploads but only 18 actually arrive, the report will hang for the full wait window before flushing. Checklist
SummaryMechanically a clean port of aio-libs/multidict#1231: Codecov action swapped for Coveralls, |
|
Follow the rules in #759 |
|
@aiolibsbot Rr |
Rebase with requested adjustmentsBranch Changes applied
StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
Rebase with requested adjustmentsBranch StatsActions performed
CI statusCI will be checked asynchronously. Automated by Kōan |
Move type coverage reporting to Coveralls per aio-libs/multidict#1231. Updates workflows to use coverallsapp/github-action, removes codecov-token secret, and drops typing config from .codecov.yml.
Head branch was pushed to by a user without write access
dc7e2cd to
aef89a2
Compare
Squash: 3 commits → 1Branch Commit messageActions
Automated by Koan |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #758 +/- ##
===========================================
+ Coverage 95.01% 100.00% +4.98%
===========================================
Files 10 2 -8
Lines 763 370 -393
Branches 51 26 -25
===========================================
- Hits 725 370 -355
+ Misses 13 0 -13
+ Partials 25 0 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Unknown command Code & Development
Pull Requests
Usage: |
What do these changes do?
Port aio-libs/multidict#1231 to frozenlist: move the MyPy type preciseness coverage report to Coveralls instead of Codecov, and remove the typing flag from the Codecov configuration.
codecov/codecov-actionstep inreusable-linters.ymlforcoverallsapp/github-action@v2with cobertura format and MyPy flag.codecov-tokensecret plumbing fromci-cd.ymlandreusable-linters.yml(Coveralls auth is via the GHA token).typingpatch/project flags from.codecov.ymland decrementafter_n_buildsfrom 20 to 19.CHANGES/756.contrib.rstdescribing the move.Are there changes in behavior for the user?
No end-user behaviour change. CI-only: MyPy type preciseness coverage now appears on Coveralls instead of Codecov.
Related issue number
Closes #756.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<category>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.bugfix: Signifying a bug fix..feature: Signifying a new feature..breaking: Signifying a breaking change or removal of something public..doc: Signifying a documentation improvement..packaging: Signifying a packaging or tooling change that may be relevant to downstreams..contrib: Signifying an improvement to the contributor/development experience..misc: Anything that does not fit the above; usually, something not of interest to users.Quality Report
Changes: 4 files changed, 14 insertions(+), 18 deletions(-)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline