Skip to content

Commit 162633e

Browse files
author
rodrigo.nogueira
committed
Revert unrelated changes to hashtable.h and pop tests
1 parent 5c1c1f2 commit 162633e

4 files changed

Lines changed: 0 additions & 71 deletions

File tree

multidict/_multilib/hashtable.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,6 @@ md_pop_one(MultiDictObject *md, PyObject *key, PyObject **ret)
10201020
}
10211021
}
10221022

1023-
Py_DECREF(identity);
10241023
ASSERT_CONSISTENT(md, false);
10251024
return 0;
10261025
fail:

tests/isolated/multidict_pop.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -62,16 +62,6 @@ def _test_popone() -> None:
6262
check_for_leak()
6363

6464

65-
def _test_pop_with_default() -> None:
66-
result = MultiDict()
67-
# XXX: mypy wants an annotation so the only
68-
# thing we can do here is pass the headers along.
69-
result = MultiDict(headers)
70-
for i in range(1_000_000):
71-
result.pop(f"missing_key_{i}", None)
72-
check_for_leak()
73-
74-
7565
def _test_del() -> None:
7666
for _ in range(10):
7767
for _ in range(100):
@@ -86,7 +76,6 @@ def _run_isolated_case() -> None:
8676
_test_popall()
8777
_test_popone()
8878
_test_del()
89-
_test_pop_with_default()
9079

9180

9281
if __name__ == "__main__":

tests/isolated/multidict_pop_missing.py

Lines changed: 0 additions & 57 deletions
This file was deleted.

tests/test_leaks.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@
1515
"multidict_extend_multidict.py",
1616
"multidict_extend_tuple.py",
1717
"multidict_update_multidict.py",
18-
"multidict_pop.py",
19-
"multidict_pop_missing.py",
2018
"multidict_to_dict.py",
2119
),
2220
)

0 commit comments

Comments
 (0)