Skip to content

Get rid of borrowed references in getters#1182

Merged
asvetlov merged 1 commit into
masterfrom
no-borrowed-refs
Jun 19, 2025
Merged

Get rid of borrowed references in getters#1182
asvetlov merged 1 commit into
masterfrom
no-borrowed-refs

Conversation

@asvetlov

Copy link
Copy Markdown
Member

The PR doesn't change anything but uses the modern Py_GetConstant() instead of borrowed reference to Py_None.

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Jun 19, 2025
@codspeed-hq

codspeed-hq Bot commented Jun 19, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1182 will improve performances by 23.94%

Comparing no-borrowed-refs (d719d96) with master (76abaac)

Summary

⚡ 4 improvements
✅ 240 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_getall_istr_hit[pure-python-module] 120.9 µs 97.7 µs +23.78%
test_cimultidict_getall_istr_miss[pure-python-module] 42.2 µs 35.1 µs +20.21%
test_multidict_getall_str_hit[case-insensitive-pure-python-module] 119.9 µs 96.7 µs +23.94%
test_multidict_getall_str_miss[case-insensitive-pure-python-module] 40.9 µs 34 µs +20.36%

@asvetlov
asvetlov merged commit 4bb923e into master Jun 19, 2025
64 checks passed
@asvetlov
asvetlov deleted the no-borrowed-refs branch June 19, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant