Skip to content

Release 6.5.1 - #1197

Merged
asvetlov merged 6 commits into
aio-libs:masterfrom
asvetlov:release-6.5.1
Jun 24, 2025
Merged

Release 6.5.1#1197
asvetlov merged 6 commits into
aio-libs:masterfrom
asvetlov:release-6.5.1

Conversation

@asvetlov

Copy link
Copy Markdown
Member

No description provided.

@asvetlov
asvetlov requested a review from webknjaz as a code owner June 24, 2025 18:30
@asvetlov
asvetlov enabled auto-merge (squash) June 24, 2025 18:30
@webknjaz

Copy link
Copy Markdown
Member

The change log should have consistent writing style. I see it's currently partially in imperative mood which would be better fitting for a TODO list or Git commits. Best to either use the past tense or explanatory present simple.

Comment thread CHANGES.rst Outdated
@asvetlov

Copy link
Copy Markdown
Member Author

Fixed, thanks!

@asvetlov
asvetlov disabled auto-merge June 24, 2025 18:42
@codspeed-hq

codspeed-hq Bot commented Jun 24, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1197 will degrade performances by 53.85%

Comparing asvetlov:release-6.5.1 (d3f8a85) with master (964d65f)

Summary

⚡ 2 improvements
❌ 4 regressions
✅ 238 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_getall_istr_hit[py] 2.3 ms 1.7 ms +32.5%
test_cimultidict_getall_istr_miss[py] 167.1 µs 357.9 µs -53.31%
test_multidict_getall_str_hit[ci-py] 2.3 ms 1.7 ms +32.77%
test_multidict_getall_str_hit[cs-py] 1.7 ms 1.8 ms -9.05%
test_multidict_getall_str_miss[ci-py] 164.2 µs 355.9 µs -53.85%
test_multidict_getall_str_miss[cs-py] 216.9 µs 270.1 µs -19.7%

@asvetlov

Copy link
Copy Markdown
Member Author

@webknjaz could you please briefly look again?

I want to release it today because 6.5.0 has a significant regression that might affect people.

Comment thread CHANGES.rst Outdated
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@asvetlov
asvetlov enabled auto-merge (squash) June 24, 2025 18:52
Comment thread CHANGES.rst Outdated
@asvetlov
asvetlov disabled auto-merge June 24, 2025 19:02
@codecov

codecov Bot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.31%. Comparing base (964d65f) to head (d3f8a85).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          27       27           
  Lines        3868     3868           
  Branches      704      704           
=======================================
  Hits         3803     3803           
  Misses         18       18           
  Partials       47       47           
Flag Coverage Δ
CI-GHA 98.31% <100.00%> (ø)
MyPy 80.44% <100.00%> (ø)
pytest 99.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread CHANGES.rst Outdated

@webknjaz webknjaz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe add one more improvement.

Comment thread CHANGES.rst
@asvetlov
asvetlov merged commit df0379f into aio-libs:master Jun 24, 2025
63 of 64 checks passed
@asvetlov
asvetlov deleted the release-6.5.1 branch June 24, 2025 21:12
@asvetlov

Copy link
Copy Markdown
Member Author

@webknjaz thank you very much for fault-finding review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants