Release 6.5.1 - #1197
Conversation
|
The change log should have consistent writing style. I see it's currently partially in imperative mood which would be better fitting for a TODO list or Git commits. Best to either use the past tense or explanatory present simple. |
|
Fixed, thanks! |
CodSpeed Performance ReportMerging #1197 will degrade performances by 53.85%Comparing Summary
Benchmarks breakdown
|
|
@webknjaz could you please briefly look again? I want to release it today because 6.5.0 has a significant regression that might affect people. |
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1197 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 27 27
Lines 3868 3868
Branches 704 704
=======================================
Hits 3803 3803
Misses 18 18
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
webknjaz
left a comment
There was a problem hiding this comment.
LGTM but maybe add one more improvement.
|
@webknjaz thank you very much for fault-finding review. |
No description provided.