Make benchmarks stable, the second attempt - #1206
Merged
Merged
Conversation
asvetlov
marked this pull request as ready for review
June 25, 2025 17:04
CodSpeed Performance ReportMerging #1206 will degrade performances by 79.79%Comparing Summary
Benchmarks breakdown
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1206 +/- ##
==========================================
- Coverage 99.85% 98.32% -1.53%
==========================================
Files 25 27 +2
Lines 3380 3874 +494
Branches 229 706 +477
==========================================
+ Hits 3375 3809 +434
- Misses 3 18 +15
- Partials 2 47 +45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problematic benchmarks now ask not the single key, but three sibling keys.
These keys have different hashes, maybe it could help with amortizing benchmark time after hash collisions.
See #1201 for details