Skip to content

fix shrink corruption - test run without fix to verify test fails on CI - #1223

Closed
bdraco wants to merge 5 commits into
aio-libs:masterfrom
bdraco:shrink_fix_ci_run
Closed

fix shrink corruption - test run without fix to verify test fails on CI#1223
bdraco wants to merge 5 commits into
aio-libs:masterfrom
bdraco:shrink_fix_ci_run

Conversation

@bdraco

@bdraco bdraco commented Jun 28, 2025

Copy link
Copy Markdown
Member

test run of #1222 without the fix to very the test fails on the CI

@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided There is a change note present in this PR label Jun 28, 2025
@bdraco

bdraco commented Jun 28, 2025

Copy link
Copy Markdown
Member Author

FAILED ../../../cibw-sdist-5180xxih/multidict-6.6.2.dev0/tests/test_mutable_multidict.py::test_multidict_shrink_regression - AssertionError: First entry k0 was lost due to memory corruption!
assert 'k0' in <MultiDict('k2': 'v2', 'k4': 'v4', 'k6': 'v6', 'k8': 'v8', 'k4': 'v4', 'new0': 'val0', 'new1': 'val1', 'new2': 'val2',...: 'val43', 'new44': 'val44', 'new45': 'val45', 'new46': 'val46', 'new47': 'val47', 'new48': 'val48', 'new49': 'val49')>

So test is catching the issue. good

@bdraco bdraco closed this Jun 28, 2025
@bdraco
bdraco deleted the shrink_fix_ci_run branch June 28, 2025 12:10
@codspeed-hq

codspeed-hq Bot commented Jun 28, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1223 will not alter performance

Comparing bdraco:shrink_fix_ci_run (18907fb) with master (863eff1)

Summary

✅ 245 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant