Skip to content

Fixed inconsistencies generated by _md_shrink. #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 1 commit into from
Jun 30, 2025
Merged

Fixed inconsistencies generated by _md_shrink. #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/1229.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed inconsistencies generated by the C implementation of ``_md_shrink()`` which might later lead to assertion failures and crash -- by :user:`Romain-Geissler-1A`.
1 change: 1 addition & 0 deletions multidict/_multilib/hashtable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ _md_shrink(MultiDictObject *md, bool update)
keys->nentries = newnentries;
keys->usable += nentries - newnentries;
memset(&keys->indices[0], 0xff, ((size_t)1 << keys->log2_index_bytes));
memset(new_ep, 0, sizeof(entry_t) * (size_t)(nentries - newnentries));
if (htkeys_build_indices(keys, entries, newnentries, update) < 0) {
return -1;
}
Expand Down
Loading