From 97ce0edf25b227feb23d1c7cf35bf14d29eceb1f Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Mon, 7 Jul 2025 03:40:31 +0200 Subject: [PATCH 1/3] Move reporting MyPy type preciseness to Coveralls --- .codecov.yml | 9 +-------- .github/workflows/ci-cd.yml | 2 -- .github/workflows/reusable-linters.yml | 22 +++++++++------------- 3 files changed, 10 insertions(+), 23 deletions(-) diff --git a/.codecov.yml b/.codecov.yml index 66d13b63b..840837630 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -2,7 +2,7 @@ codecov: notify: - after_n_builds: 2 # The number of test matrix+lint jobs uploading coverage + after_n_builds: 1 # The number of test matrix+lint jobs uploading coverage wait_for_ci: false require_ci_to_pass: false @@ -21,9 +21,6 @@ coverage: target: 95% flags: - pytest - typing: - flags: - - MyPy project: lib: flags: @@ -37,10 +34,6 @@ coverage: paths: - tests/ target: 100% - typing: - flags: - - MyPy - target: 40% github_checks: annotations: false diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index cdffe12bf..2457650df 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -106,8 +106,6 @@ jobs: lint: uses: ./.github/workflows/reusable-linters.yml - secrets: - codecov-token: ${{ secrets.CODECOV_TOKEN }} build-wheels-for-tested-arches: name: >- # ${{ '' } is a hack to nest jobs under the same sidebar category diff --git a/.github/workflows/reusable-linters.yml b/.github/workflows/reusable-linters.yml index f45495ffc..a43c51bc9 100644 --- a/.github/workflows/reusable-linters.yml +++ b/.github/workflows/reusable-linters.yml @@ -4,10 +4,6 @@ name: Linters on: workflow_call: - secrets: - codecov-token: - description: Mandatory token for uploading to Codecov - required: true env: COLOR: >- # Supposedly, pytest or coveragepy use this @@ -60,18 +56,18 @@ jobs: - name: Run linters run: | make lint - - name: Send coverage data to Codecov - uses: codecov/codecov-action@v5 + - name: Send coverage data to Coveralls + uses: coverallsapp/github-action@v2 with: - token: ${{ secrets.codecov-token }} + debug: ${{ runner.debug == 1 && true || false }} + fail-on-error: ${{ runner.debug == 1 && false || true }} files: >- - .tox/.tmp/.mypy/python-3.13/cobertura.xml, - .tox/.tmp/.mypy/python-3.11/cobertura.xml, + .tox/.tmp/.mypy/python-3.13/cobertura.xml + .tox/.tmp/.mypy/python-3.11/cobertura.xml .tox/.tmp/.mypy/python-3.9/cobertura.xml - flags: >- - CI-GHA, - MyPy - fail_ci_if_error: true + flag-name: MyPy + format: cobertura + measure: ${{ runner.debug == 1 && true || false }} - name: Install spell checker run: | pip install -r requirements/doc.txt From 19f085e90e681d2ebaa6d15bf3ebfa78251987e4 Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Mon, 7 Jul 2025 11:53:26 +0200 Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=A9=B9=20Drop=20MyPy=203.9=20ref=20fr?= =?UTF-8?q?om=20the=20linters=20workflow?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This was missed in #1046. --- .github/workflows/reusable-linters.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/reusable-linters.yml b/.github/workflows/reusable-linters.yml index a43c51bc9..3cea0d741 100644 --- a/.github/workflows/reusable-linters.yml +++ b/.github/workflows/reusable-linters.yml @@ -64,7 +64,6 @@ jobs: files: >- .tox/.tmp/.mypy/python-3.13/cobertura.xml .tox/.tmp/.mypy/python-3.11/cobertura.xml - .tox/.tmp/.mypy/python-3.9/cobertura.xml flag-name: MyPy format: cobertura measure: ${{ runner.debug == 1 && true || false }} From 736f1797fd9981ace6b553472ef5eabc2d6ddbc3 Mon Sep 17 00:00:00 2001 From: Sviatoslav Sydorenko Date: Mon, 7 Jul 2025 14:24:36 +0200 Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=93=9D=20Add=20a=20change=20note=20fo?= =?UTF-8?q?r=20PR=20#1231?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- CHANGES/1122.contrib.rst | 6 ++++++ CHANGES/1231.contrib.rst | 1 + 2 files changed, 7 insertions(+) create mode 100644 CHANGES/1122.contrib.rst create mode 120000 CHANGES/1231.contrib.rst diff --git a/CHANGES/1122.contrib.rst b/CHANGES/1122.contrib.rst new file mode 100644 index 000000000..aa700103e --- /dev/null +++ b/CHANGES/1122.contrib.rst @@ -0,0 +1,6 @@ +The type preciseness coverage report generated by `MyPy +`__ is now uploaded to `Coveralls +`__ and +will not be included in the `Codecov views +`__ going forward +-- by :user:`webknjaz`. diff --git a/CHANGES/1231.contrib.rst b/CHANGES/1231.contrib.rst new file mode 120000 index 000000000..b0b6a8ef6 --- /dev/null +++ b/CHANGES/1231.contrib.rst @@ -0,0 +1 @@ +1122.contrib.rst \ No newline at end of file