From 232aa2e70923098cb9d89272c46d104ba97e0a2d Mon Sep 17 00:00:00 2001 From: aiolibsbot Date: Mon, 18 May 2026 16:01:15 +0000 Subject: [PATCH 1/2] Move MyPy type preciseness reporting to Coveralls The MyPy cobertura report is now uploaded to Coveralls instead of Codecov, matching the convention adopted by aio-libs/multidict and aio-libs/frozenlist. Closes #239 Co-Authored-By: Claude Opus 4.7 (1M context) --- .codecov.yml | 6 +----- .github/workflows/ci-cd.yml | 2 -- .github/workflows/reusable-linters.yml | 18 +++++++----------- CHANGES/239.contrib.rst | 6 ++++++ 4 files changed, 14 insertions(+), 18 deletions(-) create mode 100644 CHANGES/239.contrib.rst diff --git a/.codecov.yml b/.codecov.yml index 37dea41d..4a3ac9ba 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -2,7 +2,7 @@ codecov: notify: - after_n_builds: 20 # The number of test matrix+lint jobs uploading coverage + after_n_builds: 19 # The number of test matrix+lint jobs uploading coverage wait_for_ci: false require_ci_to_pass: false @@ -40,9 +40,5 @@ coverage: paths: - tests/ target: 98.2% # 100% - typing: - flags: - - MyPy - target: 77.5% # 100% ... diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index f174bf59..b8bf219f 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -125,8 +125,6 @@ jobs: lint: uses: ./.github/workflows/reusable-linters.yml - secrets: - codecov-token: ${{ secrets.CODECOV_TOKEN }} build-wheels-for-tested-arches: name: >- # ${{ '' } is a hack to nest jobs under the same sidebar category diff --git a/.github/workflows/reusable-linters.yml b/.github/workflows/reusable-linters.yml index de61d73a..ef3773f2 100644 --- a/.github/workflows/reusable-linters.yml +++ b/.github/workflows/reusable-linters.yml @@ -4,10 +4,6 @@ name: Linters on: workflow_call: - secrets: - codecov-token: - description: Mandatory token for uploading to Codecov - required: true env: COLOR: >- # Supposedly, pytest or coveragepy use this @@ -66,16 +62,16 @@ jobs: - name: Run linters run: | make lint - - name: Send coverage data to Codecov - uses: codecov/codecov-action@v6 + - name: Send coverage data to Coveralls + uses: coverallsapp/github-action@v2 with: - token: ${{ secrets.codecov-token }} + debug: ${{ runner.debug == '1' && true || false }} + fail-on-error: ${{ runner.debug == '1' && false || true }} files: >- .tox/.tmp/.mypy/python-3.11/cobertura.xml - flags: >- - CI-GHA, - MyPy - fail_ci_if_error: true + flag-name: MyPy + format: cobertura + measure: ${{ runner.debug == '1' && true || false }} - name: Install spell checker run: | pip install -r requirements/doc-spelling.txt diff --git a/CHANGES/239.contrib.rst b/CHANGES/239.contrib.rst new file mode 100644 index 00000000..bfe46b77 --- /dev/null +++ b/CHANGES/239.contrib.rst @@ -0,0 +1,6 @@ +The type preciseness coverage report generated by `MyPy +`__ is now uploaded to `Coveralls +`__ and +will not be included in the `Codecov views +`__ going forward +-- by :user:`bdraco`. From a7fef806becf241607494139120ecdc6e4096da6 Mon Sep 17 00:00:00 2001 From: "J. Nick Koston" Date: Mon, 18 May 2026 09:12:36 -0700 Subject: [PATCH 2/2] Apply suggestion from @bdraco --- CHANGES/239.contrib.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES/239.contrib.rst b/CHANGES/239.contrib.rst index bfe46b77..93285c62 100644 --- a/CHANGES/239.contrib.rst +++ b/CHANGES/239.contrib.rst @@ -3,4 +3,4 @@ The type preciseness coverage report generated by `MyPy `__ and will not be included in the `Codecov views `__ going forward --- by :user:`bdraco`. +-- by :user:`aiolibsbot`.