Query argument in `retriever.get_chat_history()`

[shreehari-aiplanet]

• GenAI Stack version: 0.2.5
• Python version: 3.8
• Operating System: Ubuntu

Description

Query arguement in retriever.get_chat_history() seems a bit ambiguous. Hence it can be removed.

[dyaramatreya]

Hi @shreehari-aiplanet
Do you mean to remove the query at

genai-stack/genai_stack/retriever/base.py

Line 42 in f15b5b3

return self.mediator.get_chat_history(query=query)

?

or to remove at

genai-stack/genai_stack/retriever/base.py

Line 38 in f15b5b3

def get_chat_history(self, query:str) -> str:

[shreehari-aiplanet]

@dyaramatreya It needs to be removed wherever it is declared. Retreiver's basically getting the chat history from memory. A mediator between them is responsible for the interaction between memory and retriever to get the chat history. Hence it needs to be removed from more than 2 places.

[dyaramatreya]

@shreehari-aiplanet So basically, we have to delete this retriever.get_chat_history() method definition as well as the places where it is used. Am I correct?

[shreehari-aiplanet]

No, get_chat_history() method should exist and the query parameter that is being passed to it should be removed.

[dyaramatreya]

Ok @shreehari-aiplanet. Can I try working on this? Can you assign this issue to me? I'll make the changes and raise the PR

[dyaramatreya]

But then the query parameter passed at

genai-stack/genai_stack/stack/mediator.py

Line 72 in f15b5b3

return self._stack.memory.get_chat_history(query=query)

must also be removed right?

[shreehari-aiplanet]

But then the query parameter passed at

genai-stack/genai_stack/stack/mediator.py

Line 72 in f15b5b3

return self._stack.memory.get_chat_history(query=query)

must also be removed right?

yes

[dyaramatreya]

Thanks. Can you please assing this issue to me? I'll raise the PR in few hours

[dyaramatreya]

@shreehari-aiplanet Please have a look at the PR raised above and suggest if it's good or any changes are needed.
Thanks