Do not merge: experiment — enable ALL fix flags to newSDK defaults#183
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Draft
Do not merge: experiment — enable ALL fix flags to newSDK defaults#183Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Contributor
|
Generated Code Drift Detected The committed code does not match what the generation pipeline produces. To fix: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Research PR that flips ALL remaining fix flags to their newSDK defaults (
true). This is the maximal experiment — if any combination of flags fixes theConnectionResponsemodel_rebuild bug or recovers v0.53.0 class names, it will show up here.Flags changed from
false→true:fixes.parameterOrderingFeb2024— parameter orderingfixes.requestResponseComponentNamesFeb2024— inline schema namingfixes.securityFeb2025— security handlingfixes.sharedErrorComponentsApr2025— error component deduplicationfixes.sharedNestedComponentsJan2026— nested component namingfixes.nameOverrideFeb2026— name override propagationpython.fixFlags.asyncPaginationSep2025— async paginationpython.fixFlags.responseRequiredSep2024— response requiredPRs #181 and #182 tested
sharedNestedComponentsJan2026andrequestResponseComponentNamesFeb2024individually with zero impact. This PR tests ALL flags together to check for combined effects.Testing for:
ConnectionResponsePydanticUserError (model_rebuildbug) get fixed?Link to Devin session: https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888
Requested by: Aaron ("AJ") Steers (@aaronsteers)