Skip to content

Do not merge: experiment — enable ALL fix flags to newSDK defaults#183

Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
mainfrom
devin/1782190473-experiment-all-flags-true
Draft

Do not merge: experiment — enable ALL fix flags to newSDK defaults#183
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
mainfrom
devin/1782190473-experiment-all-flags-true

Conversation

@aaronsteers

Copy link
Copy Markdown
Member

Summary

Research PR that flips ALL remaining fix flags to their newSDK defaults (true). This is the maximal experiment — if any combination of flags fixes the ConnectionResponse model_rebuild bug or recovers v0.53.0 class names, it will show up here.

Flags changed from falsetrue:

  • fixes.parameterOrderingFeb2024 — parameter ordering
  • fixes.requestResponseComponentNamesFeb2024 — inline schema naming
  • fixes.securityFeb2025 — security handling
  • fixes.sharedErrorComponentsApr2025 — error component deduplication
  • fixes.sharedNestedComponentsJan2026 — nested component naming
  • fixes.nameOverrideFeb2026 — name override propagation
  • python.fixFlags.asyncPaginationSep2025 — async pagination
  • python.fixFlags.responseRequiredSep2024 — response required

PRs #181 and #182 tested sharedNestedComponentsJan2026 and requestResponseComponentNamesFeb2024 individually with zero impact. This PR tests ALL flags together to check for combined effects.

Testing for:

  1. Does the ConnectionResponse PydanticUserError (model_rebuild bug) get fixed?
  2. Do any additional v0.53.0 class names get recovered?
  3. Are all 739 model imports still clean?

Link to Devin session: https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888
Requested by: Aaron ("AJ") Steers (@aaronsteers)

Co-Authored-By: AJ Steers <aj@airbyte.io>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@octavia-bot

octavia-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Generate SDK Job Info

Running Speakeasy SDK generation.

Job started... Check job output.
SDK generation completed successfully.

@github-actions

Copy link
Copy Markdown
Contributor

Generated Code Drift Detected

The committed code does not match what the generation pipeline produces.

To fix: Comment /generate on this PR to regenerate.

 .../createdeclarativesourcedefinitionrequest.md    |  4 +-
 docs/api/createdestinationdefinitionrequest.md     |  4 +-
 ...eorupdateorganizationoauthcredentialsrequest.md |  4 +-
 ...eateorupdateworkspaceoauthcredentialsrequest.md |  4 +-
 docs/api/createsourcedefinitionrequest.md          |  4 +-
 .../deletedeclarativesourcedefinitionrequest.md    |  4 +-
 docs/api/deletedestinationdefinitionrequest.md     |  4 +-
 .../deleteorganizationoauthcredentialsrequest.md   |  4 +-
 docs/api/deletesourcedefinitionrequest.md          |  4 +-
 docs/api/deleteworkspaceoauthcredentialsrequest.md |  4 +-
 docs/api/getdeclarativesourcedefinitionrequest.md  |  4 +-
 docs/api/getdestinationdefinitionrequest.md        |  4 +-
 docs/api/getsourcedefinitionrequest.md             |  4 +-
 docs/api/getsourcerequest.md                       |  4 +-
 docs/api/getstreampropertiesrequest.md             |  4 +-
 docs/api/listconnectionsrequest.md                 |  6 +-
 docs/api/listdestinationsrequest.md                |  4 +-
 docs/api/listjobsrequest.md                        | 12 +--
 docs/api/listpermissionsrequest.md                 |  4 +-
 docs/api/listsourcesrequest.md                     |  4 +-
 docs/api/listuserswithinanorganizationrequest.md   |  4 +-
 docs/api/listworkspacesrequest.md                  |  4 +-
 docs/api/patchconnectionrequest.md                 |  4 +-
 docs/api/patchdestinationrequest.md                |  4 +-
 docs/api/patchsourcerequest.md                     |  4 +-
 docs/api/putdestinationrequest.md                  |  4 +-
 docs/api/putsourcerequest.md                       |  4 +-
 .../updatedeclarativesourcedefinitionrequest.md    |  4 +-
 docs/api/updatedestinationdefinitionrequest.md     |  4 +-
 docs/api/updatepermissionrequest.md                |  4 +-
 docs/api/updatesourcedefinitionrequest.md          |  4 +-
 docs/api/updatetagrequest.md                       |  4 +-
 docs/api/updateworkspacerequest.md                 |  4 +-
 docs/sdks/connections/README.md                    |  4 +-
 docs/sdks/declarativesourcedefinitions/README.md   | 10 +--
 docs/sdks/destinationdefinitions/README.md         | 10 +--
 docs/sdks/destinations/README.md                   |  8 +-
 docs/sdks/jobs/README.md                           |  6 +-
 docs/sdks/organizations/README.md                  |  4 +-
 docs/sdks/permissions/README.md                    |  2 +-
 docs/sdks/sourcedefinitions/README.md              | 10 +--
 docs/sdks/sources/README.md                        |  8 +-
 docs/sdks/tags/README.md                           |  2 +-
 docs/sdks/workspaces/README.md                     |  8 +-
 .../api/createdeclarativesourcedefinition.py       | 12 +--
 src/airbyte_api/api/createdestinationdefinition.py | 12 +--
 .../createorupdateorganizationoauthcredentials.py  | 12 +--
 .../api/createorupdateworkspaceoauthcredentials.py | 12 +--
 src/airbyte_api/api/createsourcedefinition.py      | 12 +--
 .../api/deletedeclarativesourcedefinition.py       | 10 +--
 src/airbyte_api/api/deletedestinationdefinition.py | 10 +--
 .../api/deleteorganizationoauthcredentials.py      | 14 ++--
 src/airbyte_api/api/deletesourcedefinition.py      | 10 +--
 .../api/deleteworkspaceoauthcredentials.py         | 14 ++--
 .../api/getdeclarativesourcedefinition.py          | 10 +--
 src/airbyte_api/api/getdestinationdefinition.py    | 10 +--
 src/airbyte_api/api/getsourcedefinition.py         | 10 +--
 src/airbyte_api/api/listconnections.py             | 38 ++++-----
 src/airbyte_api/api/listdestinations.py            | 20 ++---
 src/airbyte_api/api/listjobs.py                    | 96 +++++++++++-----------
 src/airbyte_api/api/listpermissions.py             | 18 ++--
 src/airbyte_api/api/listsources.py                 | 20 ++---
 .../api/listuserswithinanorganization.py           | 14 ++--
 src/airbyte_api/api/listworkspaces.py              | 20 ++---
 src/airbyte_api/api/patchconnection.py             | 12 +--
 .../api/updatedeclarativesourcedefinition.py       | 18 ++--
 src/airbyte_api/api/updatedestinationdefinition.py | 18 ++--
 src/airbyte_api/api/updatepermission.py            | 12 +--
 src/airbyte_api/api/updatesourcedefinition.py      | 18 ++--
 src/airbyte_api/api/updatetag.py                   | 12 +--
 src/airbyte_api/api/updateworkspace.py             | 12 +--
 71 files changed, 345 insertions(+), 345 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant