Do not merge: experiment — overlay rename RowFilteringOperationNot to fix model_rebuild bug

[Aaron ("AJ") Steers (aaronsteers)]

Summary

Tests whether an overlay rename of RowFilteringOperationNot avoids the Speakeasy name collision that causes the ConnectionResponse model_rebuild bug.

The bug: ConnectionResponse, ConnectionsResponse, RowFilteringMapperConfiguration, and StreamConfigurations fail at instantiation with PydanticUserError: not fully defined; you should define RowFilteringOperationNot1.

Root cause hypothesis: The OpenAPI spec names both the schema and discriminator mapping target RowFilteringOperationNot. Speakeasy disambiguates by appending 1 and uses TYPE_CHECKING to break the circular import — but this creates string forward refs that Pydantic can't resolve without model_rebuild(), which the generator doesn't emit for dependent models.

This PR: Adds x-speakeasy-name-override: RowFilteringOperationNOT via overlay to avoid the collision. If successful, the generator should produce direct imports (no TYPE_CHECKING) and include model_rebuild() at file level.

Also enables the overlay in .speakeasy/workflow.yaml (was commented out as a placeholder).

Link to Devin session: https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888
Requested by: Aaron ("AJ") Steers (@aaronsteers)

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment, CI, and merge conflict monitoring

[octavia-bot]

Generate SDK Job Info

Running Speakeasy SDK generation.

Job started... Check job output.
SDK generation completed successfully.

[github-actions]

Generated Code Drift Detected

The committed code does not match what the generation pipeline produces.

To fix: Comment /generate on this PR to regenerate.

 docs/models/rowfilteringoperation.md            |  4 ++--
 src/airbyte_api/models/__init__.py              | 25 +++++++++++++++----------
 src/airbyte_api/models/rowfilteringoperation.py | 16 +++++++---------
 3 files changed, 24 insertions(+), 21 deletions(-)

[octavia-bot]

Generate SDK Job Info

Running Speakeasy SDK generation.

Job started... Check job output.
SDK generation completed successfully.

[octavia-bot]

Generate SDK Job Info

Running Speakeasy SDK generation.

Job started... Check job output.
SDK generation completed successfully.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Introduces a Speakeasy overlay workaround to eliminate a circular $ref in row filtering models, enabling generation without missed model_rebuild() calls.

Changes:

• Adds RowFilteringOperationNot model and updates RowFilteringOperation union to reference it.
• Enables the Python overlay in the Speakeasy workflow and implements an overlay action to break the recursive schema reference.
• Updates generated docs and models/__init__.py exports to reflect the new NOT model (replacing RowFilteringOperationNot1).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/airbyte_api/models/rowfilteringoperationnot.py	Adds a new generated NOT operation model with non-recursive condition typing.
src/airbyte_api/models/rowfilteringoperation.py	Updates the discriminated union to use RowFilteringOperationNot instead of the previous forward-ref Not1 type.
src/airbyte_api/models/init.py	Adjusts exports / lazy imports and removes the previous forward-ref model_rebuild() call.
overlays/python_speakeasy.yaml	Adds an overlay action that rewrites RowFilteringOperationNot.conditions.items to reference RowFilteringOperationEqual.
docs/models/rowfilteringoperationnot.md	Adds docs for the newly generated NOT model.
docs/models/rowfilteringoperation.md	Updates docs to reference RowFilteringOperationNot instead of RowFilteringOperationNot1.
.speakeasy/workflow.yaml	Enables applying the overlay during code generation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

🚩 Old rowfilteringoperationnot_1.py file not deleted — dead code left behind

The old file src/airbyte_api/models/rowfilteringoperationnot_1.py still exists on disk but is no longer imported or referenced by anything in the codebase. The __init__.py no longer maps RowFilteringOperationNot1 in its lazy loading dict or __all__ list. The file is harmless dead code, but it could confuse contributors. Its companion doc docs/models/rowfilteringoperationnot1.md also remains. This likely happened because Speakeasy's generation step adds/modifies files but doesn't automatically remove files from a previous generation run. Consider deleting both stale files, or adding a cleanup step to the generation pipeline.

---

Was this helpful? React with 👍 or 👎 to provide feedback.

[devin-ai-integration]

☑️ Resolved in PR #187. Removed both stale files (rowfilteringoperationnot_1.py and rowfilteringoperationnot1.md). Confirmed zero references to RowFilteringOperationNot1 in the codebase.