-
Notifications
You must be signed in to change notification settings - Fork 27
feat!: migrate to Speakeasy Python v2 generator infrastructure #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aaron ("AJ") Steers (aaronsteers)
merged 1 commit into
main
from
devin/1782162749-pr1a-infrastructure
Jun 22, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,18 @@ | ||
| # This allows generated code to be indexed correctly | ||
| *.py linguist-generated=false | ||
| # Generated by Speakeasy — do not hand-edit these paths. | ||
| # See CONTRIBUTING.md for the full code-generation lineage. | ||
|
|
||
| src/ linguist-generated=true | ||
| docs/ linguist-generated=true | ||
| README.md linguist-generated=true | ||
| README-PYPI.md linguist-generated=true | ||
| USAGE.md linguist-generated=true | ||
| py.typed linguist-generated=true | ||
| uv.lock linguist-generated=true | ||
| pyproject.toml linguist-generated=true | ||
|
|
||
| # Generated lock/metadata files | ||
| .speakeasy/gen.lock linguist-generated=true | ||
| .speakeasy/workflow.lock linguist-generated=true | ||
|
|
||
| # Generated editor/tool config | ||
| .vscode/ linguist-generated=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Speakeasy CLI version pin. Bumped by Dependabot's `docker-compose` | ||
| # ecosystem; never invoked via `docker compose` (hence `dummy-`). | ||
| # Consumed by `.github/workflows/generate-command.yml`, which pulls the | ||
| # image and copies `/usr/local/bin/speakeasy` onto the runner. | ||
|
|
||
| services: | ||
| speakeasy: | ||
| image: ghcr.io/speakeasy-api/speakeasy:v1.784.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,19 @@ | ||
| **/__pycache__/ | ||
| pyrightconfig.json | ||
| **/.speakeasy/temp/ | ||
| **/.speakeasy/logs/ | ||
| .speakeasy/reports | ||
| .env.local | ||
| .python-version | ||
| .DS_Store | ||
| venv/ | ||
| .venv/ | ||
| src/*.egg-info/ | ||
| __pycache__/ | ||
| .pytest_cache/ | ||
| .python-version` | ||
| .env | ||
| dist/ | ||
| build/ | ||
| *.egg-info/ | ||
| # Generated OpenAPI spec (fetched fresh each generation run) | ||
| *.openapi.yaml |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Auto-merge on push/schedule PRs uses github.token which won't trigger CI workflows
The "Authenticate as GitHub App" step (line 69) only runs when
github.event.inputs.pr != '', meaning forpushandscheduleevents the workflow falls back togithub.token. PRs created bypeter-evans/create-pull-request@v6withgithub.tokenwill NOT trigger downstreamon: pull_requestworkflows (this is a well-known GitHub Actions limitation). The "Enable auto-merge" step at line 256 then callsgh pr merge --auto --squash, but if branch protection requires passing status checks, those checks will never run and auto-merge will wait indefinitely.Currently this isn't a problem because
test-full.ymlis a stub (if: false), so there are no required checks. However, once real CI checks are implemented in follow-up PRs, this will silently break the auto-merge flow for push/schedule-triggered generation PRs. Consider also authenticating as the GitHub App for push/schedule events, or documenting this limitation.Was this helpful? React with 👍 or 👎 to provide feedback.