-
Notifications
You must be signed in to change notification settings - Fork 27
ci: scope generation validation to generation-affecting files only #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
f05dcad
963ed3f
c4a2572
b65fefc
38c2f1c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,12 @@ | |
| # workflow that never runs as "expected" (pending), which blocks required checks. | ||
| # Instead, we filter paths at the job level so skipped jobs report as "skipped" | ||
| # (equivalent to "passed" for required checks). | ||
| # | ||
| # The path filter is scoped to generation-affecting files only (Speakeasy config, | ||
| # gen.yaml, overlays, scripts, src/, etc.). Dev dependency updates (mypy, pylint, | ||
| # etc.) skip the generation validation because they don't change generated | ||
| # artifacts, and Dependabot PRs lack the SPEAKEASY_API_KEY secret needed to run | ||
| # the generation pipeline. | ||
|
|
||
| name: Test (Full) | ||
|
|
||
|
|
@@ -39,19 +45,26 @@ jobs: | |
| with: | ||
| filters: | | ||
| generation: | ||
| - '**' | ||
| - '!README.md' | ||
| - '!docs/**' | ||
| - '.speakeasy/**' | ||
| - '.genignore' | ||
| - '.github/speakeasy/**' | ||
| - '.github/workflows/generate-command.yml' | ||
| - 'gen.yaml' | ||
| - 'overlays/**' | ||
| - 'README.md' | ||
| - 'scripts/**' | ||
| - 'poe_tasks.toml' | ||
| - 'src/**' | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's better to move this into the generate workflow. It's no longer needed here and it is needed there. Rather than calculate here and pass the Boolean, just calculate it there.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ☑️ Resolved in 38c2f1c. Moved the path filter entirely into
|
||
| outputs: | ||
| should_run: ${{ github.event_name == 'workflow_dispatch' || steps.filter.outputs.generation == 'true' }} | ||
|
|
||
| validate: | ||
| name: Validate Generation (Dry Run) | ||
| needs: check-paths | ||
| if: needs.check-paths.outputs.should_run == 'true' | ||
| uses: ./.github/workflows/generate-command.yml | ||
| with: | ||
| dry_run: true | ||
| should_run: ${{ needs.check-paths.outputs.should_run == 'true' }} | ||
| secrets: inherit | ||
|
|
||
|
aaronsteers marked this conversation as resolved.
|
||
| zero-diff: | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.