Skip to content

ci: scope generation validation to generation-affecting files only #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaron ("AJ") Steers (aaronsteers) merged 5 commits into from
Jun 23, 2026
Merged

ci: scope generation validation to generation-affecting files only #173

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f05dcad
ci: scope generation validation to generation-affecting files only
devin-ai-integration[bot] Jun 23, 2026
963ed3f
ci: add README.md to generation path filter
devin-ai-integration[bot] Jun 23, 2026
c4a2572
ci: clarify header comment about why dep-only PRs skip generation
devin-ai-integration[bot] Jun 23, 2026
b65fefc
ci: move skip condition into generate-command.yml so inner job report…
devin-ai-integration[bot] Jun 23, 2026
38c2f1c
ci: move path filter entirely into generate-command.yml
devin-ai-integration[bot] Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/test-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@
# workflow that never runs as "expected" (pending), which blocks required checks.
# Instead, we filter paths at the job level so skipped jobs report as "skipped"
# (equivalent to "passed" for required checks).
#
# The path filter is scoped to generation-affecting files only (Speakeasy config,
# gen.yaml, overlays, scripts, src/, etc.). Dev dependency updates (mypy, pylint,
# etc.) skip the generation validation since they cannot affect generated code.

@devin-ai-integration devin-ai-integration Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️ Resolved in c4a2572. Reworded the comment to explain both reasons: dev deps don't change generated artifacts, and Dependabot PRs lack SPEAKEASY_API_KEY.

Devin session


name: Test (Full)

Expand All @@ -39,9 +43,15 @@ jobs:
with:
filters: |
generation:
- '**'
- '!README.md'
- '!docs/**'
- '.speakeasy/**'
- '.genignore'
- '.github/speakeasy/**'
- '.github/workflows/generate-command.yml'
- 'gen.yaml'
Comment thread
aaronsteers marked this conversation as resolved.
Outdated
- 'overlays/**'
- 'scripts/**'
- 'poe_tasks.toml'
- 'src/**'
Comment thread
aaronsteers marked this conversation as resolved.
Outdated

@aaronsteers Aaron ("AJ") Steers (aaronsteers) Jun 23, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to move this into the generate workflow. It's no longer needed here and it is needed there. Rather than calculate here and pass the Boolean, just calculate it there.

@devin-ai-integration devin-ai-integration Bot Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☑️ Resolved in 38c2f1c. Moved the path filter entirely into generate-command.yml:

  • New check-paths job inside generate-command.yml runs only during dry_run mode
  • Generate SDK job: if: always() && (!inputs.dry_run || needs.check-paths.outputs.should_run == 'true')
  • test-full.yml simplified — no more check-paths job or should_run input, just calls generate-command.yml directly

Devin session

outputs:
should_run: ${{ github.event_name == 'workflow_dispatch' || steps.filter.outputs.generation == 'true' }}

Expand Down
Loading