Do not merge: experiment — revert nameResolutionFeb2025 to measure rename impact#180
Closed
Aaron ("AJ") Steers (aaronsteers) wants to merge 2 commits into
Closed
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Contributor
|
Generated Code Drift Detected The committed code does not match what the generation pipeline produces. To fix: Comment |
Contributor
|
Closing — analysis showed reverting nameResolutionFeb2025 hurts backward compat (63% vs 68% of v0.53.0 names preserved). Both flags should stay enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Research PR to measure the rename impact of
nameResolutionFeb2025.PR #179 enabled two fix flags:
nameResolutionFeb2025andconflictResistantModelImportsFeb2026. Testing showedconflictResistantModelImportsFeb2026was the one that actually fixed the remaining forward-referenceNameErrorinSourceResponse.nameResolutionFeb2025only fixedConnectionResponsebut may be adding unnecessary class renames.This PR reverts
nameResolutionFeb2025back tofalsewhile keepingconflictResistantModelImportsFeb2026: true. After generation, we can diff model names against main to see how many renamesnameResolutionFeb2025caused and whether we can drop it to minimize breaking changes vs 0.53.0.Link to Devin session: https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888
Requested by: Aaron ("AJ") Steers (@aaronsteers)