Do not merge: experiment — enable sharedNestedComponentsJan2026 to test Schemas-pattern name recovery#181
Conversation
…ern name recovery Co-Authored-By: AJ Steers <aj@airbyte.io>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
Closing — sharedNestedComponentsJan2026 had zero impact on generated model names. The regenerated code was identical to main. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| securityFeb2025: false | ||
| sharedErrorComponentsApr2025: false | ||
| sharedNestedComponentsJan2026: false | ||
| sharedNestedComponentsJan2026: true |
There was a problem hiding this comment.
🚩 Enabling sharedNestedComponentsJan2026 will change generated SDK output
Toggling sharedNestedComponentsJan2026 from false to true at gen.yaml:15 will alter the Speakeasy code generation output the next time the SDK is regenerated. This flag likely changes how nested components are shared/deduplicated in the generated models. The PR only changes the config — it does not include the corresponding regenerated SDK code. This is expected per the repo's workflow (config changes are committed first, then /generate is run on the PR or regeneration is triggered via CI), but the reviewer should ensure regeneration is triggered before merge so the generated code under src/airbyte_api/ reflects this flag change and passes the zero-diff drift check.
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
🚫 Not fixing. This is an experiment/research PR (note the "Do not merge" title). Generation was already triggered and completed — the result showed zero impact on generated code. The zero-diff check failure is expected since this PR intentionally changes gen config. Keeping open per maintainer request as evidence of what this flag does.
There was a problem hiding this comment.
Pull request overview
This PR enables the Speakeasy generation fix flag fixes.sharedNestedComponentsJan2026 to evaluate whether it recovers previously-lost Schemas-pattern model/class names and improves naming consistency after the v0.53.0 → v1.0.0 upgrade.
Changes:
- Flip
sharedNestedComponentsJan2026fromfalsetotrueingen.yamlgeneration fix flags.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| securityFeb2025: false | ||
| sharedErrorComponentsApr2025: false | ||
| sharedNestedComponentsJan2026: false | ||
| sharedNestedComponentsJan2026: true |
There was a problem hiding this comment.
🚫 Not fixing. Same as above — this is a "Do not merge" research PR. Generation was already triggered and completed; the flag produced zero diff in generated code. The drift failure is expected and intentional.
Summary
Research PR to measure the naming impact of enabling
fixes.sharedNestedComponentsJan2026: true.v0.53.0 → v1.0.0 lost 481 class names with the
Schemasnaming pattern (e.g.DestinationAstraSchemasEmbeddingMode). This flag "fixes component naming when the same schema is referenced in multiple places within nested structures, ensuring consistent naming based on the original component definition." Testing whether it recovers any of those names or changes the naming pattern closer to v0.53.0.Companion to PR #180 (closed —
nameResolutionFeb2025revert hurt compat).Link to Devin session: https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888
Requested by: Aaron ("AJ") Steers (@aaronsteers)