Do not merge: experiment — enable requestResponseComponentNamesFeb2024 to test prefix name recovery#182
Draft
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Conversation
…x name recovery Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Contributor
|
Closing — requestResponseComponentNamesFeb2024 had zero impact on generated model names. The regenerated code was identical to main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Research PR to measure the naming impact of enabling
fixes.requestResponseComponentNamesFeb2024: true.v0.53.0 → v1.0.0 lost 142 class names that got parent-prefixed (e.g.
APIHost→SourceEbayFulfillmentAPIHost,AWSRegion→SourceAmazonSellerPartnerAWSRegion). This flag "names inline schemas within request and response components with the component name of the parent if only one content type is defined." Testing whether it changes the prefixing behavior closer to v0.53.0.Companion to PR #180 (closed) and PR #181 (
sharedNestedComponentsJan2026).Link to Devin session: https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888
Requested by: Aaron ("AJ") Steers (@aaronsteers)