-
Notifications
You must be signed in to change notification settings - Fork 49
Expand file tree
/
Copy pathconcurrent_read_processor.py
More file actions
490 lines (444 loc) · 24.7 KB
/
Copy pathconcurrent_read_processor.py
File metadata and controls
490 lines (444 loc) · 24.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
import logging
import os
from typing import Dict, Iterable, List, Optional, Set
from airbyte_cdk.exception_handler import generate_failed_streams_error_message
from airbyte_cdk.models import AirbyteMessage, AirbyteStreamStatus, FailureType, StreamDescriptor
from airbyte_cdk.models import Type as MessageType
from airbyte_cdk.sources.concurrent_source.partition_generation_completed_sentinel import (
PartitionGenerationCompletedSentinel,
)
from airbyte_cdk.sources.concurrent_source.stream_thread_exception import StreamThreadException
from airbyte_cdk.sources.concurrent_source.thread_pool_manager import ThreadPoolManager
from airbyte_cdk.sources.declarative.partition_routers.grouping_partition_router import (
GroupingPartitionRouter,
)
from airbyte_cdk.sources.declarative.partition_routers.substream_partition_router import (
SubstreamPartitionRouter,
)
from airbyte_cdk.sources.declarative.partition_routers.union_partition_router import (
UnionPartitionRouter,
)
from airbyte_cdk.sources.message import MessageRepository
from airbyte_cdk.sources.streams.concurrent.abstract_stream import AbstractStream
from airbyte_cdk.sources.streams.concurrent.default_stream import DefaultStream
from airbyte_cdk.sources.streams.concurrent.partition_enqueuer import PartitionEnqueuer
from airbyte_cdk.sources.streams.concurrent.partition_reader import PartitionReader
from airbyte_cdk.sources.streams.concurrent.partitions.partition import Partition
from airbyte_cdk.sources.streams.concurrent.partitions.types import PartitionCompleteSentinel
from airbyte_cdk.sources.types import Record
from airbyte_cdk.sources.utils.record_helper import stream_data_to_airbyte_message
from airbyte_cdk.sources.utils.slice_logger import SliceLogger
from airbyte_cdk.utils import AirbyteTracedException
from airbyte_cdk.utils.stream_status_utils import (
as_airbyte_message as stream_status_as_airbyte_message,
)
class ConcurrentReadProcessor:
def __init__(
self,
stream_instances_to_read_from: List[AbstractStream],
partition_enqueuer: PartitionEnqueuer,
thread_pool_manager: ThreadPoolManager,
logger: logging.Logger,
slice_logger: SliceLogger,
message_repository: MessageRepository,
partition_reader: PartitionReader,
max_concurrent_partition_generators: Optional[int] = None,
):
"""
This class is responsible for handling items from a concurrent stream read process.
:param stream_instances_to_read_from: List of streams to read from
:param partition_enqueuer: PartitionEnqueuer instance
:param thread_pool_manager: ThreadPoolManager instance
:param logger: Logger instance
:param slice_logger: SliceLogger instance
:param message_repository: MessageRepository instance
:param partition_reader: PartitionReader instance
:param max_concurrent_partition_generators: Maximum number of partition generators allowed
to run concurrently. None means no limit. When set, should be less than the number of
workers in multi-worker mode so at least one worker slot is always available for
partition reading, preventing thread pool starvation. In single-threaded mode
(num_workers=1) the value may equal num_workers; ConcurrentSource.create() handles
this distinction. ConcurrentSource.read() passes this value explicitly.
"""
self._stream_name_to_instance = {s.name: s for s in stream_instances_to_read_from}
self._record_counter = {}
self._streams_to_running_partitions: Dict[str, Set[Partition]] = {}
for stream in stream_instances_to_read_from:
self._streams_to_running_partitions[stream.name] = set()
self._record_counter[stream.name] = 0
if (
max_concurrent_partition_generators is not None
and max_concurrent_partition_generators < 1
):
raise ValueError(
f"max_concurrent_partition_generators must be >= 1 or None, got {max_concurrent_partition_generators}"
)
self._thread_pool_manager = thread_pool_manager
self._partition_enqueuer = partition_enqueuer
self._max_concurrent_partition_generators = max_concurrent_partition_generators
self._stream_instances_to_start_partition_generation = stream_instances_to_read_from
self._streams_currently_generating_partitions: List[str] = []
self._logger = logger
self._slice_logger = slice_logger
self._message_repository = message_repository
self._partition_reader = partition_reader
self._streams_done: Set[str] = set()
self._exceptions_per_stream_name: dict[str, List[Exception]] = {}
# Track which streams (by name) are currently active
# A stream is "active" if it's generating partitions or has partitions being read
self._active_stream_names: Set[str] = set()
# Store blocking group names for streams that require blocking simultaneous reads
# Maps stream name -> group name (empty string means no blocking)
self._stream_block_simultaneous_read: Dict[str, str] = {
stream.name: stream.block_simultaneous_read for stream in stream_instances_to_read_from
}
# Track which groups are currently active
# Maps group name -> set of stream names in that group
self._active_groups: Dict[str, Set[str]] = {}
for stream in stream_instances_to_read_from:
if stream.block_simultaneous_read:
self._logger.info(
f"Stream '{stream.name}' is in blocking group '{stream.block_simultaneous_read}'. "
f"Will defer starting this stream if another stream in the same group or its parents are active."
)
def on_partition_generation_completed(
self, sentinel: PartitionGenerationCompletedSentinel
) -> Iterable[AirbyteMessage]:
"""
This method is called when a partition generation is completed.
1. Remove the stream from the list of streams currently generating partitions
2. Deactivate parent streams (they were only needed for partition generation)
3. If the stream is done, mark it as such and return a stream status message
4. If there are more streams to read from, start the next partition generator
"""
stream_name = sentinel.stream.name
self._streams_currently_generating_partitions.remove(sentinel.stream.name)
# Deactivate all parent streams now that partition generation is complete
# Parents were only needed to generate slices, they can now be reused
parent_streams = self._collect_all_parent_stream_names(stream_name)
for parent_stream_name in parent_streams:
if parent_stream_name in self._active_stream_names:
self._logger.debug(f"Removing '{parent_stream_name}' from active streams")
self._active_stream_names.discard(parent_stream_name)
# Remove from active groups
parent_group = self._stream_block_simultaneous_read.get(parent_stream_name, "")
if parent_group:
if parent_group in self._active_groups:
self._active_groups[parent_group].discard(parent_stream_name)
if not self._active_groups[parent_group]:
del self._active_groups[parent_group]
self._logger.info(
f"Parent stream '{parent_stream_name}' (group '{parent_group}') deactivated after "
f"partition generation completed for child '{stream_name}'. "
f"Blocked streams in the queue will be retried on next start_next_partition_generator call."
)
# It is possible for the stream to already be done if no partitions were generated
# If the partition generation process was completed and there are no partitions left to process, the stream is done
if (
self._is_stream_done(stream_name)
or len(self._streams_to_running_partitions[stream_name]) == 0
):
yield from self._on_stream_is_done(stream_name)
if self._stream_instances_to_start_partition_generation:
status_message = self.start_next_partition_generator()
if status_message:
yield status_message
def on_partition(self, partition: Partition) -> None:
"""
This method is called when a partition is generated.
1. Add the partition to the set of partitions for the stream
2. Log the slice if necessary
3. Submit the partition to the thread pool manager
"""
stream_name = partition.stream_name()
self._streams_to_running_partitions[stream_name].add(partition)
cursor = self._stream_name_to_instance[stream_name].cursor
if self._slice_logger.should_log_slice_message(self._logger):
self._message_repository.emit_message(
self._slice_logger.create_slice_log_message(partition.to_slice())
)
self._thread_pool_manager.submit(
self._partition_reader.process_partition, partition, cursor
)
def on_partition_complete_sentinel(
self, sentinel: PartitionCompleteSentinel
) -> Iterable[AirbyteMessage]:
"""
This method is called when a partition is completed.
1. Close the partition
2. If the stream is done, mark it as such and return a stream status message
3. Emit messages that were added to the message repository
4. If there are more streams to read from, start the next partition generator
"""
partition = sentinel.partition
partitions_running = self._streams_to_running_partitions[partition.stream_name()]
if partition in partitions_running:
partitions_running.remove(partition)
# If all partitions were generated and this was the last one, the stream is done
if (
partition.stream_name() not in self._streams_currently_generating_partitions
and len(partitions_running) == 0
):
yield from self._on_stream_is_done(partition.stream_name())
# Try to start the next stream in the queue (may be a deferred stream)
if self._stream_instances_to_start_partition_generation:
status_message = self.start_next_partition_generator()
if status_message:
yield status_message
yield from self._message_repository.consume_queue()
def on_record(self, record: Record) -> Iterable[AirbyteMessage]:
"""
This method is called when a record is read from a partition.
1. Convert the record to an AirbyteMessage
2. If this is the first record for the stream, mark the stream as RUNNING
3. Increment the record counter for the stream
4. Ensures the cursor knows the record has been successfully emitted
5. Emit the message
6. Emit messages that were added to the message repository
"""
# Do not pass a transformer or a schema
# AbstractStreams are expected to return data as they are expected.
# Any transformation on the data should be done before reaching this point
message = stream_data_to_airbyte_message(
stream_name=record.stream_name,
data_or_message=record.data,
file_reference=record.file_reference,
)
stream = self._stream_name_to_instance[record.stream_name]
if message.type == MessageType.RECORD:
if self._record_counter[stream.name] == 0:
self._logger.info(f"Marking stream {stream.name} as RUNNING")
yield stream_status_as_airbyte_message(
stream.as_airbyte_stream(), AirbyteStreamStatus.RUNNING
)
self._record_counter[stream.name] += 1
yield message
yield from self._message_repository.consume_queue()
def on_exception(self, exception: StreamThreadException) -> Iterable[AirbyteMessage]:
"""
This method is called when an exception is raised.
1. Stop all running streams
2. Raise the exception
"""
self._flag_exception(exception.stream_name, exception.exception)
self._logger.exception(
f"Exception while syncing stream {exception.stream_name}", exc_info=exception.exception
)
stream_descriptor = StreamDescriptor(name=exception.stream_name)
if isinstance(exception.exception, AirbyteTracedException):
yield exception.exception.as_airbyte_message(stream_descriptor=stream_descriptor)
else:
yield AirbyteTracedException.from_exception(
exception.exception,
stream_descriptor=stream_descriptor,
message=f"An unexpected error occurred in stream {exception.stream_name}: {type(exception.exception).__name__}",
).as_airbyte_message()
def _flag_exception(self, stream_name: str, exception: Exception) -> None:
self._exceptions_per_stream_name.setdefault(stream_name, []).append(exception)
def start_next_partition_generator(self) -> Optional[AirbyteMessage]:
"""
Submits the next partition generator to the thread pool.
A stream will be deferred (moved to end of queue) if:
1. The stream itself has block_simultaneous_read=True AND is already active
2. Any parent stream has block_simultaneous_read=True AND is currently active
This prevents simultaneous reads of streams that shouldn't be accessed concurrently.
:return: A status message if a partition generator was started, otherwise None
"""
if not self._stream_instances_to_start_partition_generation:
return None
# Enforce the concurrent generator cap so at least one worker slot is always available
# for partition reading. Recovery is guaranteed: on_partition_generation_completed
# decrements the count before calling here, so the guard always passes there.
if (
self._max_concurrent_partition_generators is not None
and len(self._streams_currently_generating_partitions)
>= self._max_concurrent_partition_generators
):
self._logger.debug(
f"Concurrent partition generator cap ({self._max_concurrent_partition_generators}) reached "
f"({len(self._streams_currently_generating_partitions)} active). Deferring next generator start."
)
return None
# Remember initial queue size to avoid infinite loops if all streams are blocked
max_attempts = len(self._stream_instances_to_start_partition_generation)
attempts = 0
while self._stream_instances_to_start_partition_generation and attempts < max_attempts:
attempts += 1
# Pop the first stream from the queue
stream = self._stream_instances_to_start_partition_generation.pop(0)
stream_name = stream.name
stream_group = self._stream_block_simultaneous_read.get(stream_name, "")
# Check if this stream has a blocking group and is already active as parent stream
# (i.e. being read from during partition generation for another stream)
if stream_group and stream_name in self._active_stream_names:
# Add back to the END of the queue for retry later
self._stream_instances_to_start_partition_generation.append(stream)
self._logger.info(
f"Deferring stream '{stream_name}' (group '{stream_group}') because it's already active. Trying next stream."
)
continue # Try the next stream in the queue
# Check if this stream's group is already active (another stream in the same group is running)
if (
stream_group
and stream_group in self._active_groups
and self._active_groups[stream_group]
):
# Add back to the END of the queue for retry later
self._stream_instances_to_start_partition_generation.append(stream)
active_streams_in_group = self._active_groups[stream_group]
self._logger.info(
f"Deferring stream '{stream_name}' (group '{stream_group}') because other stream(s) "
f"{active_streams_in_group} in the same group are active. Trying next stream."
)
continue # Try the next stream in the queue
# Check if any parent streams have a blocking group and are currently active
parent_streams = self._collect_all_parent_stream_names(stream_name)
blocked_by_parents = [
p
for p in parent_streams
if self._stream_block_simultaneous_read.get(p, "")
and p in self._active_stream_names
]
if blocked_by_parents:
# Add back to the END of the queue for retry later
self._stream_instances_to_start_partition_generation.append(stream)
parent_groups = {
self._stream_block_simultaneous_read.get(p, "") for p in blocked_by_parents
}
self._logger.info(
f"Deferring stream '{stream_name}' because parent stream(s) "
f"{blocked_by_parents} (groups {parent_groups}) are active. Trying next stream."
)
continue # Try the next stream in the queue
# No blocking - start this stream
# Mark stream as active before starting
self._active_stream_names.add(stream_name)
self._streams_currently_generating_partitions.append(stream_name)
# Track this stream in its group if it has one
if stream_group:
if stream_group not in self._active_groups:
self._active_groups[stream_group] = set()
self._active_groups[stream_group].add(stream_name)
self._logger.debug(f"Added '{stream_name}' to active group '{stream_group}'")
# Also mark all parent streams as active (they will be read from during partition generation)
for parent_stream_name in parent_streams:
parent_group = self._stream_block_simultaneous_read.get(parent_stream_name, "")
if parent_group:
self._active_stream_names.add(parent_stream_name)
if parent_group not in self._active_groups:
self._active_groups[parent_group] = set()
self._active_groups[parent_group].add(parent_stream_name)
self._logger.info(
f"Marking parent stream '{parent_stream_name}' (group '{parent_group}') as active "
f"(will be read during partition generation for '{stream_name}')"
)
self._thread_pool_manager.submit(self._partition_enqueuer.generate_partitions, stream)
self._logger.info(f"Marking stream {stream_name} as STARTED")
self._logger.info(f"Syncing stream: {stream_name}")
return stream_status_as_airbyte_message(
stream.as_airbyte_stream(),
AirbyteStreamStatus.STARTED,
)
# All streams in the queue are currently blocked
return None
def is_done(self) -> bool:
"""
This method is called to check if the sync is done.
The sync is done when:
1. There are no more streams generating partitions
2. There are no more streams to read from
3. All partitions for all streams are closed
"""
is_done = all(
[
self._is_stream_done(stream_name)
for stream_name in self._stream_name_to_instance.keys()
]
)
if is_done and self._stream_instances_to_start_partition_generation:
stuck_stream_names = [
s.name for s in self._stream_instances_to_start_partition_generation
]
raise AirbyteTracedException(
message="Partition generation queue is not empty after all streams completed.",
internal_message=f"Streams {stuck_stream_names} remained in the partition generation queue after all streams were marked done.",
failure_type=FailureType.system_error,
)
if is_done and self._active_groups:
raise AirbyteTracedException(
message="Active stream groups are not empty after all streams completed.",
internal_message=f"Groups {dict(self._active_groups)} still active after all streams were marked done.",
failure_type=FailureType.system_error,
)
if is_done and self._exceptions_per_stream_name:
error_message = generate_failed_streams_error_message(self._exceptions_per_stream_name)
self._logger.info(error_message)
# We still raise at least one exception when a stream raises an exception because the platform currently relies
# on a non-zero exit code to determine if a sync attempt has failed. We also raise the exception as a config_error
# type because this combined error isn't actionable, but rather the previously emitted individual errors.
raise AirbyteTracedException(
message=error_message,
internal_message="Concurrent read failure",
failure_type=FailureType.config_error,
)
return is_done
def _is_stream_done(self, stream_name: str) -> bool:
return stream_name in self._streams_done
def _collect_all_parent_stream_names(self, stream_name: str) -> Set[str]:
"""Recursively collect all parent stream names for a given stream.
For example, if we have: epics -> issues -> comments
Then for comments, this returns {issues, epics}.
"""
parent_names: Set[str] = set()
stream = self._stream_name_to_instance.get(stream_name)
if not stream:
return parent_names
partition_router = (
stream.get_partition_router() if isinstance(stream, DefaultStream) else None
)
routers = [partition_router] if partition_router else []
while routers:
router = routers.pop()
if isinstance(router, GroupingPartitionRouter):
routers.append(router.underlying_partition_router)
elif isinstance(router, UnionPartitionRouter):
routers.extend(router.partition_routers)
elif isinstance(router, SubstreamPartitionRouter):
for parent_config in router.parent_stream_configs:
parent_name = parent_config.stream.name
parent_names.add(parent_name)
parent_names.update(self._collect_all_parent_stream_names(parent_name))
return parent_names
def _on_stream_is_done(self, stream_name: str) -> Iterable[AirbyteMessage]:
self._logger.info(
f"Read {self._record_counter[stream_name]} records from {stream_name} stream"
)
self._logger.info(f"Marking stream {stream_name} as STOPPED")
stream = self._stream_name_to_instance[stream_name]
stream.cursor.ensure_at_least_one_state_emitted()
yield from self._message_repository.consume_queue()
self._logger.info(f"Finished syncing {stream.name}")
self._streams_done.add(stream_name)
stream_status = (
AirbyteStreamStatus.INCOMPLETE
if self._exceptions_per_stream_name.get(stream_name, [])
else AirbyteStreamStatus.COMPLETE
)
yield stream_status_as_airbyte_message(stream.as_airbyte_stream(), stream_status)
# Remove only this stream from active set (NOT parents)
if stream_name in self._active_stream_names:
self._active_stream_names.discard(stream_name)
# Remove from active groups
stream_group = self._stream_block_simultaneous_read.get(stream_name, "")
if stream_group:
if stream_group in self._active_groups:
self._active_groups[stream_group].discard(stream_name)
if not self._active_groups[stream_group]:
del self._active_groups[stream_group]
self._logger.info(
f"Stream '{stream_name}' (group '{stream_group}') is no longer active. "
f"Blocked streams in the queue will be retried on next start_next_partition_generator call."
)