-
Notifications
You must be signed in to change notification settings - Fork 44
Expand file tree
/
Copy pathtest_composite_decoder.py
More file actions
441 lines (364 loc) · 15.9 KB
/
test_composite_decoder.py
File metadata and controls
441 lines (364 loc) · 15.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
#
# Copyright (c) 2024 Airbyte, Inc., all rights reserved.
#
import csv
import gzip
import json
import socket
from http.server import BaseHTTPRequestHandler, HTTPServer
from io import BytesIO, StringIO
from threading import Thread
from typing import ClassVar, Iterable, List
from unittest.mock import Mock, patch
import pytest
import requests
from airbyte_cdk.sources.declarative.decoders.composite_raw_decoder import (
CompositeRawDecoder,
CsvParser,
GzipParser,
JsonLineParser,
JsonParser,
)
from airbyte_cdk.utils import AirbyteTracedException
def find_available_port() -> int:
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as s:
s.bind(("localhost", 0))
return s.getsockname()[1] # type: ignore # this should return a int
def compress_with_gzip(data: str, encoding: str = "utf-8"):
"""
Compress the data using Gzip.
"""
buf = BytesIO()
with gzip.GzipFile(fileobj=buf, mode="wb") as f:
f.write(data.encode(encoding))
return buf.getvalue()
def generate_csv(
encoding: str = "utf-8",
delimiter: str = ",",
should_compress: bool = False,
add_extra_column: bool = False,
extra_column_value: str = "",
) -> bytes:
data = [
{"id": "1", "name": "John", "age": "28"},
{"id": "2", "name": "Alice", "age": "34"},
{"id": "3", "name": "Bob", "age": "25"},
]
fieldnames = ["id", "name", "age"]
if add_extra_column:
for row in data:
row["gender"] = extra_column_value
fieldnames.append("gender")
output = StringIO()
writer = csv.DictWriter(output, fieldnames=fieldnames, delimiter=delimiter)
writer.writeheader()
for row in data:
writer.writerow(row)
output.seek(0)
csv_data = output.read()
if should_compress:
return compress_with_gzip(csv_data, encoding=encoding)
return csv_data.encode(encoding)
@pytest.mark.parametrize("encoding", ["utf-8", "utf", "iso-8859-1"])
def test_composite_raw_decoder_gzip_csv_parser(requests_mock, encoding: str):
requests_mock.register_uri(
"GET",
"https://airbyte.io/",
content=generate_csv(encoding=encoding, delimiter="\t", should_compress=True),
headers={"Content-Encoding": "gzip"},
)
response = requests.get("https://airbyte.io/", stream=True)
# the delimiter is set to `\\t` intentionally to test the parsing logic here
parser = GzipParser(inner_parser=CsvParser(encoding=encoding, delimiter="\\t"))
composite_raw_decoder = CompositeRawDecoder(parser=parser)
counter = 0
for _ in composite_raw_decoder.decode(response):
counter += 1
assert counter == 3
def generate_jsonlines() -> Iterable[str]:
"""
Generator function to yield data in JSON Lines format.
This is useful for streaming large datasets.
"""
data = [
{"id": 1, "message": "Hello, World!"},
{"id": 2, "message": "Welcome to JSON Lines"},
{"id": 3, "message": "Streaming data is fun!"},
]
for item in data:
yield json.dumps(item) + "\n" # Serialize as JSON Lines
def generate_compressed_jsonlines(encoding: str = "utf-8") -> bytes:
"""
Generator to compress the entire response content with Gzip and encode it.
"""
json_lines_content = "".join(generate_jsonlines())
compressed_data = compress_with_gzip(json_lines_content, encoding=encoding)
return compressed_data
@pytest.mark.parametrize("encoding", ["utf-8", "utf", "iso-8859-1"])
def test_composite_raw_decoder_gzip_jsonline_parser(requests_mock, encoding: str):
requests_mock.register_uri(
"GET",
"https://airbyte.io/",
content=generate_compressed_jsonlines(encoding=encoding),
)
response = requests.get("https://airbyte.io/", stream=True)
parser = GzipParser(inner_parser=JsonLineParser(encoding=encoding))
composite_raw_decoder = CompositeRawDecoder(parser)
counter = 0
for _ in composite_raw_decoder.decode(response):
counter += 1
assert counter == 3
def test_given_header_match_when_decode_then_select_parser(requests_mock):
requests_mock.register_uri(
"GET",
"https://airbyte.io/",
content=generate_compressed_jsonlines(),
headers={"Content-Encoding": "gzip"},
)
response = requests.get("https://airbyte.io/", stream=True)
parser = GzipParser(inner_parser=JsonLineParser())
unused_parser = Mock()
composite_raw_decoder = CompositeRawDecoder.by_headers(
[({"Content-Encoding"}, {"gzip"}, parser)],
stream_response=True,
fallback_parser=unused_parser,
)
counter = 0
for _ in composite_raw_decoder.decode(response):
counter += 1
assert counter == 3
def test_given_header_does_not_match_when_decode_then_select_fallback_parser(requests_mock):
requests_mock.register_uri(
"GET",
"https://airbyte.io/",
content="".join(generate_jsonlines()).encode("utf-8"),
headers={"Content-Encoding": "not gzip in order to expect fallback"},
)
response = requests.get("https://airbyte.io/", stream=True)
unused_parser = GzipParser(inner_parser=Mock())
composite_raw_decoder = CompositeRawDecoder.by_headers(
[({"Content-Encoding"}, {"gzip"}, unused_parser)],
stream_response=True,
fallback_parser=JsonLineParser(),
)
counter = 0
for _ in composite_raw_decoder.decode(response):
counter += 1
assert counter == 3
@pytest.mark.parametrize("encoding", ["utf-8", "utf", "iso-8859-1"])
def test_composite_raw_decoder_jsonline_parser(requests_mock, encoding: str):
response_content = "".join(generate_jsonlines())
requests_mock.register_uri(
"GET", "https://airbyte.io/", content=response_content.encode(encoding=encoding)
)
response = requests.get("https://airbyte.io/", stream=True)
composite_raw_decoder = CompositeRawDecoder(parser=JsonLineParser(encoding=encoding))
counter = 0
for _ in composite_raw_decoder.decode(response):
counter += 1
assert counter == 3
@pytest.mark.parametrize(
"test_data",
[
({"data-type": "string"}),
([{"id": "1"}, {"id": "2"}]),
({"id": "170141183460469231731687303715884105727"}),
({}),
({"nested": {"foo": {"bar": "baz"}}}),
],
ids=[
"valid_dict",
"list_of_dicts",
"int128",
"empty_object",
"nested_structure",
],
)
def test_composite_raw_decoder_json_parser(requests_mock, test_data):
encodings = ["utf-8", "utf", "iso-8859-1"]
for encoding in encodings:
raw_data = json.dumps(test_data).encode(encoding=encoding)
requests_mock.register_uri("GET", "https://airbyte.io/", content=raw_data)
response = requests.get("https://airbyte.io/", stream=True)
composite_raw_decoder = CompositeRawDecoder(parser=JsonParser(encoding=encoding))
actual = list(composite_raw_decoder.decode(response))
if isinstance(test_data, list):
assert actual == test_data
else:
assert actual == [test_data]
def test_composite_raw_decoder_orjson_parser_error(requests_mock):
raw_data = json.dumps({"test": "test"}).encode("utf-8")
requests_mock.register_uri("GET", "https://airbyte.io/", content=raw_data)
response = requests.get("https://airbyte.io/", stream=True)
composite_raw_decoder = CompositeRawDecoder(parser=JsonParser(encoding="utf-8"))
with patch("orjson.loads", side_effect=Exception("test")):
assert [{"test": "test"}] == list(composite_raw_decoder.decode(response))
def test_composite_raw_decoder_raises_traced_exception_when_both_parsers_fail(requests_mock):
raw_data = json.dumps({"test": "test"}).encode("utf-8")
requests_mock.register_uri("GET", "https://airbyte.io/", content=raw_data)
response = requests.get("https://airbyte.io/", stream=True)
composite_raw_decoder = CompositeRawDecoder(parser=JsonParser(encoding="utf-8"))
with patch("orjson.loads", side_effect=Exception("test")):
with patch("json.loads", side_effect=Exception("test")):
with pytest.raises(AirbyteTracedException):
list(composite_raw_decoder.decode(response))
@pytest.mark.parametrize("encoding", ["utf-8", "utf", "iso-8859-1"])
@pytest.mark.parametrize("delimiter", [",", "\t", ";"])
def test_composite_raw_decoder_csv_parser_values(requests_mock, encoding: str, delimiter: str):
requests_mock.register_uri(
"GET",
"https://airbyte.io/",
content=generate_csv(encoding=encoding, delimiter=delimiter, should_compress=False),
)
response = requests.get("https://airbyte.io/", stream=True)
parser = CsvParser(encoding=encoding, delimiter=delimiter)
composite_raw_decoder = CompositeRawDecoder(parser=parser)
expected_data = [
{"id": "1", "name": "John", "age": "28"},
{"id": "2", "name": "Alice", "age": "34"},
{"id": "3", "name": "Bob", "age": "25"},
]
parsed_records = list(composite_raw_decoder.decode(response))
assert parsed_records == expected_data
@pytest.mark.parametrize("set_values_to_none", [None, [""], ["--"]])
def test_composite_raw_decoder_parse_empty_strings(
requests_mock, set_values_to_none: List[str] | None
):
requests_mock.register_uri(
"GET",
"https://airbyte.io/",
content=generate_csv(
should_compress=False,
add_extra_column=True,
extra_column_value=set_values_to_none[0] if set_values_to_none else "random_value",
),
)
response = requests.get("https://airbyte.io/", stream=True)
parser = CsvParser(set_values_to_none=set_values_to_none)
composite_raw_decoder = CompositeRawDecoder(parser=parser)
expected_data = [
{"id": "1", "name": "John", "age": "28"},
{"id": "2", "name": "Alice", "age": "34"},
{"id": "3", "name": "Bob", "age": "25"},
]
for expected_record in expected_data:
expected_record["gender"] = None if set_values_to_none else "random_value"
parsed_records = list(composite_raw_decoder.decode(response))
assert parsed_records == expected_data
class TestServer(BaseHTTPRequestHandler):
__test__: ClassVar[bool] = False # Tell Pytest this is not a Pytest class, despite its name
def do_GET(self) -> None:
self.send_response(200)
self.end_headers()
self.wfile.write(bytes("col1,col2\nval1,val2", "utf-8"))
def test_composite_raw_decoder_csv_parser_without_mocked_response():
"""
This test reproduce a `ValueError: I/O operation on closed file` error we had with CSV parsing. We could not catch this with other tests because the closing of the mocked response from requests_mock was not the same as the one in requests.
We first identified this issue while working with the sample defined https://people.sc.fsu.edu/~jburkardt/data/csv/addresses.csv.
This should be reproducible by having the test server return the `self.wfile.write` statement as a comment below but it does not. However, it wasn't reproducible.
Currently we use `self.wfile.write(bytes("col1,col2\nval1,val2", "utf-8"))` to reproduce which we know is not a valid csv as it does not end with a newline character. However, this is the only we were able to reproduce locally.
"""
# self.wfile.write(bytes('John,Doe,120 jefferson st.,Riverside, NJ, 08075\nJack,McGinnis,220 hobo Av.,Phila, PA,09119\n"John ""Da Man""",Repici,120 Jefferson St.,Riverside, NJ,08075\nStephen,Tyler,"7452 Terrace ""At the Plaza"" road",SomeTown,SD, 91234\n,Blankman,,SomeTown, SD, 00298\n"Joan ""the bone"", Anne",Jet,"9th, at Terrace plc",Desert City,CO,00123\n', "utf-8"))
# start server
port = find_available_port()
httpd = HTTPServer(("localhost", port), TestServer)
thread = Thread(target=httpd.serve_forever, args=())
thread.start()
try:
response = requests.get(f"http://localhost:{port}", stream=True)
result = list(CompositeRawDecoder(parser=CsvParser()).decode(response))
assert len(result) == 1
finally:
httpd.shutdown() # release port and kill the thread
thread.join(timeout=5) # ensure thread is cleaned up
def _generate_csv_with_metadata(
metadata_lines: int = 0,
post_header_lines: int = 0,
encoding: str = "utf-8",
delimiter: str = ",",
) -> bytes:
"""Generate CSV bytes with metadata lines before and/or after the header."""
lines = []
for i in range(metadata_lines):
lines.append(f"# metadata line {i + 1}")
header = delimiter.join(["id", "name", "age"])
lines.append(header)
for i in range(post_header_lines):
lines.append(f"# post-header line {i + 1}")
lines.append(delimiter.join(["1", "John", "28"]))
lines.append(delimiter.join(["2", "Alice", "34"]))
return ("\n".join(lines) + "\n").encode(encoding)
@pytest.mark.parametrize(
"skip_before,skip_after,metadata_lines,post_header_lines,expected_count",
[
pytest.param(0, 0, 0, 0, 2, id="no_skip_rows_default_behavior"),
pytest.param(3, 0, 3, 0, 2, id="skip_3_rows_before_header"),
pytest.param(0, 2, 0, 2, 2, id="skip_2_rows_after_header"),
pytest.param(2, 1, 2, 1, 2, id="skip_both_before_and_after"),
pytest.param(1, 0, 1, 0, 2, id="skip_1_row_before_header"),
],
)
def test_csv_parser_skip_rows(
requests_mock,
skip_before: int,
skip_after: int,
metadata_lines: int,
post_header_lines: int,
expected_count: int,
):
"""Verify CsvParser skips metadata rows before and/or after the header."""
csv_content = _generate_csv_with_metadata(
metadata_lines=metadata_lines,
post_header_lines=post_header_lines,
)
requests_mock.register_uri("GET", "https://airbyte.io/", content=csv_content)
response = requests.get("https://airbyte.io/", stream=True)
parser = CsvParser(
skip_rows_before_header=skip_before,
skip_rows_after_header=skip_after,
)
composite_raw_decoder = CompositeRawDecoder(parser=parser)
parsed_records = list(composite_raw_decoder.decode(response))
assert len(parsed_records) == expected_count
assert parsed_records[0] == {"id": "1", "name": "John", "age": "28"}
assert parsed_records[1] == {"id": "2", "name": "Alice", "age": "34"}
def test_csv_parser_skip_rows_before_header_with_tsv(requests_mock):
"""Verify skip_rows_before_header works with TSV (tab-delimited) data, matching the reporter's use case."""
csv_content = _generate_csv_with_metadata(
metadata_lines=3,
delimiter="\t",
)
requests_mock.register_uri("GET", "https://airbyte.io/", content=csv_content)
response = requests.get("https://airbyte.io/", stream=True)
parser = CsvParser(
delimiter="\t",
skip_rows_before_header=3,
)
composite_raw_decoder = CompositeRawDecoder(parser=parser)
parsed_records = list(composite_raw_decoder.decode(response))
assert len(parsed_records) == 2
assert parsed_records[0] == {"id": "1", "name": "John", "age": "28"}
def test_given_response_already_consumed_when_decode_then_no_data_is_returned(requests_mock):
requests_mock.register_uri(
"GET", "https://airbyte.io/", content=json.dumps({"test": "test"}).encode()
)
response = requests.get("https://airbyte.io/", stream=True)
composite_raw_decoder = CompositeRawDecoder(parser=JsonParser(encoding="utf-8"))
content = list(composite_raw_decoder.decode(response))
assert content
with pytest.raises(Exception):
list(composite_raw_decoder.decode(response))
def test_given_response_is_not_streamed_when_decode_then_can_be_called_multiple_times(
requests_mock,
):
requests_mock.register_uri(
"GET", "https://airbyte.io/", content=json.dumps({"test": "test"}).encode()
)
response = requests.get("https://airbyte.io/")
composite_raw_decoder = CompositeRawDecoder(
parser=JsonParser(encoding="utf-8"),
stream_response=False,
)
content = list(composite_raw_decoder.decode(response))
content_second_time = list(composite_raw_decoder.decode(response))
assert content == content_second_time