fix: Address Copilot review comments

- Fix YAML bullet point indentation for consistency (Comment 8)
- Add type guard for cursor_value to handle unexpected types (Comment 9)
- Add test for warning log emission when cursor is too old (Comment 10)

Co-Authored-By: unknown <>

Author: devin-ai-integration[bot]

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

@@ -3757,12 +3757,12 @@ definitions:
         description: |
           The data retention period of the incremental API (ISO8601 duration). If the cursor value is older than this retention period, the connector will automatically fall back to a full refresh to avoid data loss.
           This is useful for APIs like Stripe Events API which only retain data for 30 days.
-            * **PT1H**: 1 hour
-            * **P1D**: 1 day
-            * **P1W**: 1 week
-            * **P1M**: 1 month
-            * **P1Y**: 1 year
-            * **P30D**: 30 days
+          * **PT1H**: 1 hour
+          * **P1D**: 1 day
+          * **P1W**: 1 week
+          * **P1M**: 1 month
+          * **P1Y**: 1 year
+          * **P30D**: 30 days
         type: string
         examples:
           - "P30D"

airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py

@@ -3609,6 +3609,9 @@ def _is_cursor_older_than_retention_period(
         if not cursor_value:
             return False
 
+        if not isinstance(cursor_value, (str, int)):
+            return False
+
         retention_duration = parse_duration(api_retention_period)
         retention_cutoff = datetime.datetime.now(datetime.timezone.utc) - retention_duration
 

unit_tests/sources/declarative/test_state_delegating_stream.py

@@ -4,9 +4,11 @@
 
 import copy
 import json
+import logging
 from unittest.mock import MagicMock
 
 import freezegun
+import pytest
 
 from airbyte_cdk.models import (
     AirbyteStateBlob,
@@ -370,3 +372,37 @@ def test_cursor_age_validation_with_1_day_retention_falls_back():
 
         records = get_records(source, _CONFIG, configured_catalog, state)
         assert len(records) == 1
+
+
+@freezegun.freeze_time("2024-07-15")
+def test_cursor_age_validation_emits_warning_when_falling_back(caplog):
+    """Test that a warning is emitted when cursor is older than retention period."""
+    manifest = _create_manifest_with_retention_period("P7D")
+
+    with HttpMocker() as http_mocker:
+        http_mocker.get(
+            HttpRequest(url="https://api.test.com/items"),
+            HttpResponse(body=json.dumps([{"id": 1, "updated_at": "2024-07-14"}])),
+        )
+
+        state = [
+            AirbyteStateMessage(
+                type=AirbyteStateType.STREAM,
+                stream=AirbyteStreamState(
+                    stream_descriptor=StreamDescriptor(name="TestStream", namespace=None),
+                    stream_state=AirbyteStateBlob(updated_at="2024-07-01"),
+                ),
+            )
+        ]
+
+        with caplog.at_level(logging.WARNING):
+            source = ConcurrentDeclarativeSource(
+                source_config=manifest, config=_CONFIG, catalog=None, state=state
+            )
+            configured_catalog = create_configured_catalog(source, _CONFIG)
+            get_records(source, _CONFIG, configured_catalog, state)
+
+        warning_messages = [r.message for r in caplog.records if r.levelno == logging.WARNING]
+        assert any("TestStream" in msg and "older than" in msg and "P7D" in msg for msg in warning_messages), (
+            f"Expected warning about stale cursor not found. Warnings: {warning_messages}"
+        )