fix: gate --components-path file execution behind AIRBYTE_ENABLE_UNSAFE_CODE

Co-Authored-By: Daryna Ishchenko <darina.ishchenko17@gmail.com>

Author: devin-ai-integration[bot]

airbyte_cdk/cli/source_declarative_manifest/_run.py

@@ -43,6 +43,10 @@
 from airbyte_cdk.sources.declarative.concurrent_declarative_source import (
     ConcurrentDeclarativeSource,
 )
+from airbyte_cdk.sources.declarative.parsers.custom_code_compiler import (
+    AirbyteCustomCodeNotPermittedError,
+    custom_code_execution_permitted,
+)
 from airbyte_cdk.sources.declarative.yaml_declarative_source import YamlDeclarativeSource
 from airbyte_cdk.sources.source import TState
 from airbyte_cdk.utils.datetime_helpers import ab_datetime_now
@@ -279,10 +283,17 @@ def _parse_manifest_from_file(filepath: str) -> dict[str, Any] | None:
 
 
 def _register_components_from_file(filepath: str) -> None:
-    """Load and register components from a Python file specified in the args."""
+    """Load and register components from a Python file specified in the args.
+
+    The file is caller-supplied Python that is executed via `exec_module`, so it is
+    untrusted code and must be gated behind `AIRBYTE_ENABLE_UNSAFE_CODE`.
+    """
     import importlib.util
     import sys
 
+    if not custom_code_execution_permitted():
+        raise AirbyteCustomCodeNotPermittedError
+
     components_path = Path(filepath)
 
     module_name = "components"

unit_tests/source_declarative_manifest/test_source_declarative_w_custom_components.py

@@ -288,10 +288,34 @@ def _read_fn(*args, **kwargs):
             _read_fn()
 
 
-def test_register_components_from_file(components_file: str) -> None:
-    """Test that components can be properly loaded from a file."""
+def test_register_components_from_file(
+    components_file: str,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """Test that components can be properly loaded from a file when custom code is permitted."""
+    monkeypatch.setenv(ENV_VAR_ALLOW_CUSTOM_CODE, "true")
+
     # Register the components
     _register_components_from_file(components_file)
 
     # Verify the components were loaded correctly
     verify_components_loaded()
+
+
+def test_register_components_from_file_is_gated(
+    components_file: str,
+    monkeypatch: pytest.MonkeyPatch,
+) -> None:
+    """A `--components-path` file is caller-supplied Python executed via `exec_module`.
+
+    It must be gated behind `AIRBYTE_ENABLE_UNSAFE_CODE`: with the env var unset the file must
+    not be executed and the loader must raise `AirbyteCustomCodeNotPermittedError` before any
+    module-level code runs.
+    """
+    monkeypatch.delenv(ENV_VAR_ALLOW_CUSTOM_CODE, raising=False)
+
+    with pytest.raises(AirbyteCustomCodeNotPermittedError):
+        _register_components_from_file(components_file)
+
+    assert "components" not in sys.modules
+    assert "source_declarative_manifest.components" not in sys.modules