Commit 39ac22e
refactor: Evaluate page_size in __post_init__ instead of get_page_size()
This change evaluates the interpolated page_size once during initialization
rather than on every get_page_size() call, matching the pattern used by
PageIncrement. This is more efficient and catches configuration errors
earlier at initialization time.
Co-Authored-By: alfredo.garcia@airbyte.io <freddy.garcia7.fg@gmail.com>1 parent 54d4e2d commit 39ac22e
2 files changed
Lines changed: 14 additions & 21 deletions
File tree
- airbyte_cdk/sources/declarative/requesters/paginators/strategies
- unit_tests/sources/declarative/requesters/paginators
Lines changed: 7 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
| 57 | + | |
| 58 | + | |
62 | 59 | | |
63 | | - | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
| 106 | + | |
Lines changed: 7 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
147 | | - | |
148 | | - | |
149 | | - | |
150 | | - | |
151 | | - | |
152 | | - | |
153 | | - | |
| 147 | + | |
154 | 148 | | |
155 | | - | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
0 commit comments