Commit 3c50ce4
fix: pass stream_slicer when creating retriever in DynamicSchemaLoader
In create_dynamic_schema_loader, the retriever was created with only
partition_router but not stream_slicer. This caused AsyncRetriever
creation to fail with 'missing required keyword-only argument:
stream_slicer' since AsyncRetriever requires stream_slicer as a
keyword-only argument while SimpleRetriever accepts partition_router.
The fix mirrors the pattern used in create_default_stream, passing
both stream_slicer and partition_router when creating the retriever.
Resolves #766
Co-Authored-By: bot_apk <apk@cognition.ai>1 parent 69cd63d commit 3c50ce4
2 files changed
Lines changed: 99 additions & 4 deletions
File tree
- airbyte_cdk/sources/declarative/parsers
- unit_tests/sources/declarative/parsers
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2565 | 2565 | | |
2566 | 2566 | | |
2567 | 2567 | | |
| 2568 | + | |
2568 | 2569 | | |
2569 | 2570 | | |
2570 | 2571 | | |
2571 | 2572 | | |
2572 | 2573 | | |
2573 | | - | |
2574 | | - | |
2575 | | - | |
| 2574 | + | |
| 2575 | + | |
2576 | 2576 | | |
2577 | 2577 | | |
2578 | 2578 | | |
| |||
Lines changed: 96 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
163 | 167 | | |
164 | 168 | | |
165 | 169 | | |
| |||
4160 | 4164 | | |
4161 | 4165 | | |
4162 | 4166 | | |
| 4167 | + | |
| 4168 | + | |
| 4169 | + | |
| 4170 | + | |
| 4171 | + | |
| 4172 | + | |
| 4173 | + | |
| 4174 | + | |
| 4175 | + | |
| 4176 | + | |
| 4177 | + | |
| 4178 | + | |
| 4179 | + | |
| 4180 | + | |
| 4181 | + | |
| 4182 | + | |
| 4183 | + | |
| 4184 | + | |
| 4185 | + | |
| 4186 | + | |
| 4187 | + | |
| 4188 | + | |
| 4189 | + | |
| 4190 | + | |
| 4191 | + | |
| 4192 | + | |
| 4193 | + | |
| 4194 | + | |
| 4195 | + | |
| 4196 | + | |
| 4197 | + | |
| 4198 | + | |
| 4199 | + | |
| 4200 | + | |
| 4201 | + | |
| 4202 | + | |
| 4203 | + | |
| 4204 | + | |
| 4205 | + | |
| 4206 | + | |
| 4207 | + | |
| 4208 | + | |
| 4209 | + | |
| 4210 | + | |
| 4211 | + | |
| 4212 | + | |
| 4213 | + | |
| 4214 | + | |
| 4215 | + | |
| 4216 | + | |
| 4217 | + | |
| 4218 | + | |
| 4219 | + | |
| 4220 | + | |
| 4221 | + | |
| 4222 | + | |
| 4223 | + | |
| 4224 | + | |
| 4225 | + | |
| 4226 | + | |
| 4227 | + | |
| 4228 | + | |
| 4229 | + | |
| 4230 | + | |
| 4231 | + | |
| 4232 | + | |
| 4233 | + | |
| 4234 | + | |
| 4235 | + | |
| 4236 | + | |
| 4237 | + | |
| 4238 | + | |
| 4239 | + | |
| 4240 | + | |
| 4241 | + | |
| 4242 | + | |
| 4243 | + | |
| 4244 | + | |
| 4245 | + | |
| 4246 | + | |
| 4247 | + | |
| 4248 | + | |
| 4249 | + | |
| 4250 | + | |
| 4251 | + | |
| 4252 | + | |
| 4253 | + | |
| 4254 | + | |
| 4255 | + | |
| 4256 | + | |
| 4257 | + | |
4163 | 4258 | | |
4164 | 4259 | | |
4165 | 4260 | | |
| |||
0 commit comments