Require stream_count >= 1; drop zero-means-skip behavior

Co-Authored-By: gl_anatolii.yatsuk <gl_anatolii.yatsuk@airbyte.io>

Author: devin-ai-integration[bot]

airbyte_cdk/sources/declarative/checks/check_stream.py

@@ -166,8 +166,8 @@ def _check_generated_streams_availability(
     ) -> Tuple[bool, Any]:
         """Checks availability of generated dynamic streams.
 
-        If `max_count` is `None`, all generated streams are checked. If `max_count` is 0,
-        no streams are checked. Otherwise, the first `max_count` streams are checked.
+        If `max_count` is `None`, all generated streams are checked. Otherwise, the
+        first `max_count` streams are checked (capped at the number of available streams).
         """
         streams_to_check = (
             generated_streams if max_count is None else generated_streams[:max_count]

airbyte_cdk/sources/declarative/declarative_component_schema.yaml

@@ -358,9 +358,9 @@ definitions:
         type: string
       stream_count:
         title: Stream Count
-        description: The number of streams to attempt reading from during a check operation. If unset, all generated streams are checked. If set to 0, no streams are checked. If set to a positive value greater than the total number of available streams, all streams are checked.
+        description: The number of streams to attempt reading from during a check operation. If unset, all generated streams are checked. Must be a positive integer; if it exceeds the total number of available streams, all streams are checked.
         type: integer
-        minimum: 0
+        minimum: 1
   CheckDynamicStream:
     title: Dynamic Streams to Check
     description: (This component is experimental. Use at your own risk.) Defines the dynamic streams to try reading when running a check operation.

airbyte_cdk/sources/declarative/models/declarative_component_schema.py

@@ -59,8 +59,8 @@ class DynamicStreamCheckConfig(BaseModel):
     )
     stream_count: Optional[int] = Field(
         None,
-        description="The number of streams to attempt reading from during a check operation. If unset, all generated streams are checked. If set to 0, no streams are checked. If set to a positive value greater than the total number of available streams, all streams are checked.",
-        ge=0,
+        description="The number of streams to attempt reading from during a check operation. If unset, all generated streams are checked. Must be a positive integer; if it exceeds the total number of available streams, all streams are checked.",
+        ge=1,
         title="Stream Count",
     )
 

unit_tests/sources/declarative/checks/test_check_stream.py

@@ -487,46 +487,6 @@ def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapp
             1,
             id="test_stream_count_gt_generated_streams",
         ),
-        pytest.param(
-            {
-                "check": {
-                    "type": "CheckStream",
-                    "dynamic_streams_check_configs": [
-                        {
-                            "type": "DynamicStreamCheckConfig",
-                            "dynamic_stream_name": "http_dynamic_stream",
-                            "stream_count": 0,
-                        },
-                    ],
-                }
-            },
-            Status.SUCCEEDED,
-            False,
-            200,
-            [],
-            0,
-            id="test_stream_count_zero_checks_no_streams",
-        ),
-        pytest.param(
-            {
-                "check": {
-                    "type": "CheckStream",
-                    "dynamic_streams_check_configs": [
-                        {
-                            "type": "DynamicStreamCheckConfig",
-                            "dynamic_stream_name": "http_dynamic_stream",
-                            "stream_count": 0,
-                        },
-                    ],
-                }
-            },
-            Status.SUCCEEDED,
-            False,
-            404,
-            ["Not found. The requested resource was not found on the server."],
-            0,
-            id="test_stream_count_zero_skips_failing_streams",
-        ),
         pytest.param(
             {
                 "check": {
@@ -760,8 +720,12 @@ def test_check_stream_missing_fields():
         )
 
 
-def test_check_stream_negative_stream_count():
-    """Test that a ValidationError is raised when stream_count is negative."""
+@pytest.mark.parametrize(
+    "stream_count",
+    [pytest.param(0, id="zero"), pytest.param(-1, id="negative")],
+)
+def test_check_stream_non_positive_stream_count(stream_count: int) -> None:
+    """A ValidationError is raised when stream_count is less than 1."""
     manifest = {
         **deepcopy(_MANIFEST_WITHOUT_CHECK_COMPONENT),
         **{
@@ -771,7 +735,7 @@ def test_check_stream_negative_stream_count():
                     {
                         "type": "DynamicStreamCheckConfig",
                         "dynamic_stream_name": "http_dynamic_stream",
-                        "stream_count": -1,
+                        "stream_count": stream_count,
                     }
                 ],
             }