Commit 7b95a10
fix: treat stream_count=0 as 'check all streams' in DynamicStreamCheckConfig
Previously, DynamicStreamCheckConfig.stream_count defaulted to 0, which
caused _check_generated_streams_availability to slice generated_streams[:0],
resulting in zero streams being checked. This meant connectors using
DynamicStreamCheckConfig without explicitly setting stream_count would
silently skip all dynamic stream availability checks.
Now, stream_count <= 0 means 'check all generated streams', which is the
expected behavior when no limit is specified.
Co-Authored-By: bot_apk <apk@cognition.ai>1 parent 1256a1f commit 7b95a10
2 files changed
Lines changed: 28 additions & 4 deletions
File tree
- airbyte_cdk/sources/declarative/checks
- unit_tests/sources/declarative/checks
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
164 | 164 | | |
165 | 165 | | |
166 | 166 | | |
167 | | - | |
168 | | - | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
169 | 173 | | |
170 | 174 | | |
171 | 175 | | |
| |||
Lines changed: 22 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
439 | 439 | | |
440 | 440 | | |
441 | 441 | | |
442 | | - | |
| 442 | + | |
443 | 443 | | |
444 | 444 | | |
445 | 445 | | |
| |||
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
467 | | - | |
| 467 | + | |
468 | 468 | | |
469 | 469 | | |
470 | 470 | | |
| |||
487 | 487 | | |
488 | 488 | | |
489 | 489 | | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
| 496 | + | |
| 497 | + | |
| 498 | + | |
| 499 | + | |
| 500 | + | |
| 501 | + | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
490 | 510 | | |
491 | 511 | | |
492 | 512 | | |
| |||
0 commit comments