fix(check-stream): fall back on empty stream override

Author: devin-ai-integration[bot]

airbyte_cdk/sources/declarative/checks/check_stream.py

@@ -105,14 +105,16 @@ def check_connection(
         return True, None
 
     def _get_stream_names(self, config: Mapping[str, Any]) -> List[str]:
-        if CHECK_STREAM_NAMES_CONFIG_KEY not in config:
+        if (
+            CHECK_STREAM_NAMES_CONFIG_KEY not in config
+            or config[CHECK_STREAM_NAMES_CONFIG_KEY] == []
+        ):
             return self.stream_names
         configured_stream_names = config[CHECK_STREAM_NAMES_CONFIG_KEY]
         if not isinstance(configured_stream_names, list) or not all(
             isinstance(stream_name, str) for stream_name in configured_stream_names
         ):
             raise ValueError(f"{CHECK_STREAM_NAMES_CONFIG_KEY} must be a list of strings.")
-        # An empty override intentionally skips static stream checks; dynamic stream checks still run when configured.
         return configured_stream_names
 
     def _check_stream_availability(

unit_tests/sources/declarative/checks/test_check_stream.py

@@ -98,10 +98,12 @@ def test_check_stream_names_can_be_overridden_from_config():
     static_stream.stream_slices.assert_not_called()
 
 
-def test_check_stream_names_override_accepts_empty_list():
+def test_check_stream_names_override_empty_list_falls_back_to_manifest_streams():
     stream = MagicMock(spec=Stream)
     stream.name = "static_stream"
     stream.availability_strategy = None
+    stream.read_records.return_value = iter([record])
+    stream.stream_slices.return_value = iter([{}])
     source = MagicMock()
     source.streams.return_value = [stream]
 
@@ -111,7 +113,7 @@ def test_check_stream_names_override_accepts_empty_list():
         True,
         None,
     )
-    stream.stream_slices.assert_not_called()
+    stream.stream_slices.assert_called_once()
 
 
 @pytest.mark.parametrize("override", ["selected_stream", [1], ["selected_stream", 1], None])
@@ -794,7 +796,7 @@ def test_check_stream1(
             assert connection_status.status == expected_result
 
 
-def test_check_empty_static_stream_override_still_checks_dynamic_streams():
+def test_check_empty_static_stream_override_falls_back_to_manifest_streams_and_checks_dynamic_streams():
     manifest = {
         **deepcopy(_MANIFEST_WITHOUT_CHECK_COMPONENT),
         **{
@@ -840,9 +842,9 @@ def test_check_empty_static_stream_override_still_checks_dynamic_streams():
 
         connection_status = source.check(logger, check_config)
 
-        http_mocker.assert_number_of_calls(static_stream_request, 0)
-        http_mocker.assert_number_of_calls(item_request_2, 1)
-        assert connection_status.status == Status.SUCCEEDED
+        http_mocker.assert_number_of_calls(static_stream_request, 6)
+        http_mocker.assert_number_of_calls(item_request_2, 0)
+        assert connection_status.status == Status.FAILED
 
 
 def test_check_stream_missing_fields():