fix(cdk): change MemoryLimitExceeded to system_error and update user-facing message

Co-Authored-By: bot_apk <apk@cognition.ai>

Author: devin-ai-integration[bot]

airbyte_cdk/utils/memory_monitor.py

@@ -146,9 +146,8 @@ def check_memory_usage(self) -> None:
             raise MemoryLimitExceeded(
                 internal_message=f"Memory usage is {usage_percent}% ({usage_bytes} / {limit_bytes} bytes). "
                 f"Critical threshold is {int(self._critical_threshold * 100)}%.",
-                message=f"Source exceeded memory limit ({usage_percent}% used) and must shut down. "
-                f"Reduce the number of streams or increase memory allocation.",
-                failure_type=FailureType.transient_error,
+                message=f"Source exceeded memory limit ({usage_percent}% used) and must shut down to avoid an out-of-memory crash.",
+                failure_type=FailureType.system_error,
             )
 
         if usage_ratio >= self._warning_threshold and not self._warning_emitted:

unit_tests/test_entrypoint.py

@@ -889,9 +889,8 @@ def _raise_on_second_call() -> None:
         if call_count >= 2:
             raise MemoryLimitExceeded(
                 internal_message="Memory at 96%",
-                message="Source exceeded memory limit (96% used) and must shut down. "
-                "Reduce the number of streams or increase memory allocation.",
-                failure_type=FailureType.transient_error,
+                message="Source exceeded memory limit (96% used) and must shut down to avoid an out-of-memory crash.",
+                failure_type=FailureType.system_error,
             )
 
     mocker.patch.object(

unit_tests/utils/test_memory_monitor.py

@@ -172,7 +172,7 @@ def mock_read_text(self: Path) -> str:
             with pytest.raises(MemoryLimitExceeded) as exc_info:
                 monitor.check_memory_usage()
 
-        assert exc_info.value.failure_type == FailureType.transient_error
+        assert exc_info.value.failure_type == FailureType.system_error
         assert "96%" in (exc_info.value.message or "")
 
     def test_warning_emitted_only_once(self) -> None:
@@ -375,7 +375,7 @@ def test_is_airbyte_traced_exception(self) -> None:
         exc = MemoryLimitExceeded(
             internal_message="test",
             message="test message",
-            failure_type=FailureType.transient_error,
+            failure_type=FailureType.system_error,
         )
         assert isinstance(exc, AirbyteTracedException)
 
@@ -384,9 +384,9 @@ def test_default_attributes(self) -> None:
         exc = MemoryLimitExceeded(
             internal_message="Memory at 96%",
             message="Source exceeded memory limit.",
-            failure_type=FailureType.transient_error,
+            failure_type=FailureType.system_error,
         )
-        assert exc.failure_type == FailureType.transient_error
+        assert exc.failure_type == FailureType.system_error
         assert exc.message == "Source exceeded memory limit."
         assert exc.internal_message == "Memory at 96%"