Skip to content

Commit fdf7a58

Browse files
devin-ai-integration[bot]bot_apk
andcommitted
fix(cdk): Remove remediation language from generic 400 error message
The default 400 error message contained 'Please check your request parameters' which violates the writing-good-error-messages guidelines: - Embeds remediation language ('Please check...') - Redundantly prefixes with 'HTTP Status Code: 400. Error:' - Not specific enough to be actionable Simplified to 'Bad request.' which is concise and does not embed unhelpful remediation suggestions. Connectors should use HttpResponseFilter with custom error_message templates to provide API-specific context for 400 errors. Related to airbytehq/airbyte-internal-issues#15976 Related to airbytehq/oncall#11577 Co-Authored-By: bot_apk <apk@cognition.ai>
1 parent f550424 commit fdf7a58

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

airbyte_cdk/sources/streams/http/error_handlers/default_error_mapping.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
400: ErrorResolution(
3232
response_action=ResponseAction.FAIL,
3333
failure_type=FailureType.system_error,
34-
error_message="HTTP Status Code: 400. Error: Bad request. Please check your request parameters.",
34+
error_message="Bad request.",
3535
),
3636
401: ErrorResolution(
3737
response_action=ResponseAction.FAIL,

unit_tests/sources/declarative/requesters/error_handlers/test_default_error_handler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ def test_default_error_handler_with_default_response_filter(
9292
),
9393
ResponseAction.RETRY,
9494
FailureType.system_error,
95-
"HTTP Status Code: 400. Error: Bad request. Please check your request parameters.",
95+
"Bad request.",
9696
),
9797
(
9898
"_with_http_response_status_402_fail_with_default_failure_type",

0 commit comments

Comments
 (0)