Commit fdf7a58
fix(cdk): Remove remediation language from generic 400 error message
The default 400 error message contained 'Please check your request
parameters' which violates the writing-good-error-messages guidelines:
- Embeds remediation language ('Please check...')
- Redundantly prefixes with 'HTTP Status Code: 400. Error:'
- Not specific enough to be actionable
Simplified to 'Bad request.' which is concise and does not embed
unhelpful remediation suggestions. Connectors should use
HttpResponseFilter with custom error_message templates to provide
API-specific context for 400 errors.
Related to airbytehq/airbyte-internal-issues#15976
Related to airbytehq/oncall#11577
Co-Authored-By: bot_apk <apk@cognition.ai>1 parent f550424 commit fdf7a58
2 files changed
Lines changed: 2 additions & 2 deletions
File tree
- airbyte_cdk/sources/streams/http/error_handlers
- unit_tests/sources/declarative/requesters/error_handlers
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
92 | 92 | | |
93 | 93 | | |
94 | 94 | | |
95 | | - | |
| 95 | + | |
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| |||
0 commit comments