feat(low code cdk): add path to filter interpolation in AddFields condition#454
Merged
Daryna Ishchenko (darynaishchenko) merged 2 commits intomainfrom Apr 1, 2025
Conversation
Contributor
Author
|
/autofix
|
Contributor
📝 WalkthroughWalkthroughThe pull request updates the Changes
Sequence Diagram(s)sequenceDiagram
participant C as Client
participant AF as AddFields
participant FI as FilterInterpolator
C->>AF: Call transform(record, parsed_field, ...)
AF->>FI: eval(value, kwargs, path=parsed_field.path)
FI-->>AF: Return condition result (true/false)
alt Condition True
AF->>AF: Add new field to record
else Condition False
AF->>AF: Record remains unchanged
end
AF-->>C: Return updated record
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Maxime Carbonneau-Leclerc (maxi297)
approved these changes
Apr 1, 2025
Contributor
Maxime Carbonneau-Leclerc (maxi297)
left a comment
Maxime Carbonneau-Leclerc (maxi297)
left a comment
There was a problem hiding this comment.
Daryna Ishchenko (darynaishchenko)
deleted the
daryna/low-code/add-path-to-addfields-condition
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Needed for mixpanel dynamic schemas airbytehq/airbyte#55189
When stream has static fields in schema, they should be added only when dynamic schema doesn't have these fields in it.
How
To check if field already exists in schema a condition in AddFields transformation can be used, but now it doesn't have path value in interpolation arguments.
Added
path=parsed_field.pathto_filter_interpolator.eval.Summary by CodeRabbit