Revert "fix: yield partitions for unique stream slices in StreamSlicerPartitionGenerator"

[Serhii Lazebnyi (lazebnyi)]

Reverts #508

Summary by CodeRabbit

• Refactor
  • Updated partition generation to include all stream slices without filtering out duplicates.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This change removes the deduplication logic from the StreamSlicerPartitionGenerator.generate method in the declarative_partition_generator.py module. The method no longer filters out duplicate stream slices and instead yields all partitions from the underlying StreamSlicer as-is. The static helper method _make_hashable, previously used to convert slices into hashable forms for deduplication, has also been deleted. The import of Hashable from typing was removed as it is no longer needed.

Changes

File(s)	Change Summary
airbyte_cdk/sources/declarative/stream_slicers/declarative_partition_generator.py	Removed deduplication logic from StreamSlicerPartitionGenerator.generate. Deleted _make_hashable method and unused Hashable import. Updated method signature accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant StreamSlicerPartitionGenerator
    participant StreamSlicer

    Client->>StreamSlicerPartitionGenerator: generate()
    StreamSlicerPartitionGenerator->>StreamSlicer: stream_slices()
    StreamSlicer-->>StreamSlicerPartitionGenerator: stream_slice
    StreamSlicerPartitionGenerator-->>Client: Partition (for each stream_slice, no deduplication)

Loading

Possibly related PRs

• fix: yield partitions for unique stream slices in StreamSlicerPartitionGenerator #508: This PR introduced the duplicate filtering logic and _make_hashable method, which are now being removed in the current change. Would you like to reference or coordinate with this PR to ensure consistency, wdyt?

Suggested reviewers

• brianjlai
• maxi297

Would you like to tag both reviewers since they seem familiar with this part of the codebase, wdyt?

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d665ca0 and cd5bb3f.

📒 Files selected for processing (1)

• airbyte_cdk/sources/declarative/stream_slicers/declarative_partition_generator.py (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.