Skip to content

fix: remove reference to deleted cloud wrapper Dockerfile in CDK publish workflow#656

Merged
Lake Mossman (lmossman) merged 1 commit intomainfrom
devin/1752609636-fix-cdk-publish-workflow
Jul 16, 2025
Merged

fix: remove reference to deleted cloud wrapper Dockerfile in CDK publish workflow#656
Lake Mossman (lmossman) merged 1 commit intomainfrom
devin/1752609636-fix-cdk-publish-workflow

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 15, 2025

fix: remove reference to deleted cloud wrapper Dockerfile in CDK publish workflow

Summary

This PR fixes the failing automated CDK version updates by removing a reference to a Dockerfile that was deleted in airbyte-platform-internal PR #16936. The CDK publish workflow was attempting to update cloud/airbyte-connector-builder-server-wrapped/Dockerfile, but this entire directory was removed as part of removing cloud-auth functionality.

Changes made:

  • Removed line 295 from .github/workflows/pypi_publish.yml that referenced the non-existent cloud wrapper Dockerfile
  • Preserved the OSS Dockerfile update and requirements.in update that still work correctly

Root cause: airbyte-platform-internal PR #16936 removed the entire cloud/airbyte-connector-builder-server-wrapped/ directory, but the CDK publish workflow wasn't updated accordingly.

Review & Testing Checklist for Human

  • Verify that the OSS Dockerfile path (oss/airbyte-connector-builder-server/Dockerfile) still exists in airbyte-platform-internal
  • Check that the workflow YAML syntax is valid (linting passed, but good to double-check)
  • Consider testing the workflow with a dummy CDK release to ensure no other parts break

Diagram

%%{ init : { "theme" : "default" }}%%
graph TD
    subgraph "airbyte-python-cdk"
        A["pypi_publish.yml<br/>workflow"]:::major-edit
    end
    
    subgraph "airbyte-platform-internal"
        B["oss/airbyte-connector-builder-server/<br/>Dockerfile"]:::context
        C["cloud/airbyte-connector-builder-server-wrapped/<br/>Dockerfile<br/>(DELETED)"]:::context
        D["oss/airbyte-connector-builder-server/<br/>requirements.in"]:::context
    end
    
    A -->|"updates (preserved)"| B
    A -.->|"tried to update<br/>(REMOVED)"| C
    A -->|"updates (preserved)"| D
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit  
        L3[Context/No Edit]:::context
    end

    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#87CEEB
    classDef context fill:#FFFFFF
Loading

Notes

This change resolves the CI failure shown in the Slack thread where the workflow was getting "No such file or directory" errors. The fix is minimal and surgical - only removing the problematic line while preserving all working functionality.

Link to Devin run: https://app.devin.ai/sessions/b70f94c1b76d4e1ea86f759bfe42f44a
Requested by: Aaron ("AJ") Steers (@aaronsteers)

…ish workflow

This fixes the failing automated CDK version updates by removing the reference to
cloud/airbyte-connector-builder-server-wrapped/Dockerfile which was removed in
airbyte-platform-internal PR #16936 as part of removing cloud-auth functionality.

The OSS Dockerfile update and requirements.in update are preserved.

Co-Authored-By: AJ Steers <aj@airbyte.io>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

Original prompt from AJ Steers:

SYSTEM:
=== BEGIN THREAD HISTORY (in #dev-connectors-extensibility-releases) ===
Airbyte Tooling Bot (U02UK4GS0LU): :warning: A new version of Python CDK has been released but Connector Builder hasn't been automatically updated

Python CDK `v6.59.0` has been <https://github.com/airbytehq/airbyte-python-cdk/releases|released>



:warning: Could not automatically create a PR for Connector Builder&gt;


See details on <https://github.com/airbytehq/airbyte-python-cdk/actions/runs/16300766818|GitHub>


AJ Steers (U05AKF1BCC9): <@U02T7NVJ6A3> - Doe the below mean anything to you?

ATTACHMENT:"https://app.devin.ai/attachments/cd1c90c5-f9f0-4be5-9c2a-4b77a02dbc5f/image.png"

AJ Steers (U05AKF1BCC9): I saw the failure but I'm not super familiar with that downstream process.

Lake Mossman (U02T7NVJ6A3): Part of that action is to update the CDK version in that dockerfile, but it looks like that directory doesn't exist anymore: <https://github.com/airbytehq/airbyte-platform-internal/tree/master/cloud>
Maybe it was recently removed?

AJ Steers (U05AKF1BCC9): @Devin - Can you tell us which PR removed the Dockerfile?

Devin (U089R2B6A04): Got it! Created a new session in <https://T02TET08MDH.slack.com/archives/C04J1M66D8B/p1752608754974559?thread_ts=1752608754.974559|this thread>

AJ Steers (U05AKF1BCC9): To confirm, this should be in the airbyte-platform-internal repo? `cloud/airbyte-connector-builder-server-wrapped/Dockerfile` ?

AJ Steers (U05AKF1BCC9): <https://airbytehq-team.slack.com/archives/C04J1M66D8B/p1752608893744629?thread_ts=1752608754.974559&amp;cid=C04J1M66D8B>

Quote of conversation (https://airbytehq-team.slack.com/archives/C04J1M66D8B/p1752608893744629?thread_ts=1752608754.974559&amp;cid=C04J1M66D8B):
> From Devin
> The Dockerfile was removed by PR #16936 "chore: remove cloud-auth" on July 14, 2025. This PR removed the entire `cloud/airbyte-connector-builder-server-wrapped/` directory. This explains why the automated CDK update is failing.
> You can view the PR here: <https://github.com/airbytehq/airbyte-platform-internal/pull/16936>
> Posted on July 15, 2025 at 07:48 PM


AJ Steers (U05AKF1BCC9): <@U07FH2Y34A1> - Do you have some extra context on this?

Alex Buchanan (U07FH2Y34A1): The wrapped version of the connector builder was removed.

Alex Buchanan (U07FH2Y34A1): <https://github.com/airbytehq/airbyte-platform-internal/pull/16936>

#16936 chore: remove cloud-auth

AJ Steers (U05AKF1BCC9): I don't really have any context on this...

<@U02T7NVJ6A3> - Do you know what this means for delivering/testing SDM backend for the builder, and what to do with the warning?

> :warning: Could not automatically create a PR for Connector Builder>

Alex Buchanan (U07FH2Y34A1): The connector-builder-server-wrapped was just a thin wrapper around connector-builder-server for Cloud, which added some auth handling. That special auth handling has been removed.

If the CI workflow that's broken here is still updating the CDK version in <https://github.com/airbytehq/airbyte-platform-internal/tree/master/oss/airbyte-connector-builder-server>, then you should be good to just remove the failing line.

AJ Steers (U05AKF1BCC9): Thanks. That's super helpful. I don't know if I have time to pick this up but I'll let Devin give it a try. <@U02T7NVJ6A3>, let me know if you end up having time to pick this up.

AJ Steers (U05AKF1BCC9): @Devin - can you find the CDK publish process that runs to create a PR against the internal platform repo? We'd like to confirm if we can simply remove the update to the now-removed docker file, and if the version bump still happens in another location within the repo.
=== END THREAD HISTORY ===

The latest message is the one right above that tagged you.

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

devin-ai-integration bot commented Jul 15, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added bug Something isn't working security labels Jul 15, 2025
@github-actions
Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1752609636-fix-cdk-publish-workflow#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1752609636-fix-cdk-publish-workflow

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for my part.

Lake Mossman (@lmossman) - I think you are probably the best to approve and merge if all looks good.

@github-actions
Copy link
Copy Markdown

PyTest Results (Fast)

3 695 tests  ±0   3 684 ✅ ±0   6m 14s ⏱️ -4s
    1 suites ±0      11 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 3a3f75f. ± Comparison against base commit b711cd6.

Copy link
Copy Markdown
Contributor

@lmossman Lake Mossman (lmossman) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmossman Lake Mossman (lmossman) merged commit ff16dbf into main Jul 16, 2025
20 checks passed
@lmossman Lake Mossman (lmossman) deleted the devin/1752609636-fix-cdk-publish-workflow branch July 16, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants