fix: remove reference to deleted cloud wrapper Dockerfile in CDK publish workflow#656
Merged
Lake Mossman (lmossman) merged 1 commit intomainfrom Jul 16, 2025
Conversation
…ish workflow This fixes the failing automated CDK version updates by removing the reference to cloud/airbyte-connector-builder-server-wrapped/Dockerfile which was removed in airbyte-platform-internal PR #16936 as part of removing cloud-auth functionality. The OSS Dockerfile update and requirements.in update are preserved. Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
Author
|
Original prompt from AJ Steers: |
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1752609636-fix-cdk-publish-workflow#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1752609636-fix-cdk-publish-workflowHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Aaron ("AJ") Steers (aaronsteers)
approved these changes
Jul 15, 2025
Member
Aaron ("AJ") Steers (aaronsteers)
left a comment
There was a problem hiding this comment.
Approved for my part.
Lake Mossman (@lmossman) - I think you are probably the best to approve and merge if all looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: remove reference to deleted cloud wrapper Dockerfile in CDK publish workflow
Summary
This PR fixes the failing automated CDK version updates by removing a reference to a Dockerfile that was deleted in airbyte-platform-internal PR #16936. The CDK publish workflow was attempting to update
cloud/airbyte-connector-builder-server-wrapped/Dockerfile, but this entire directory was removed as part of removing cloud-auth functionality.Changes made:
.github/workflows/pypi_publish.ymlthat referenced the non-existent cloud wrapper DockerfileRoot cause: airbyte-platform-internal PR #16936 removed the entire
cloud/airbyte-connector-builder-server-wrapped/directory, but the CDK publish workflow wasn't updated accordingly.Review & Testing Checklist for Human
oss/airbyte-connector-builder-server/Dockerfile) still exists in airbyte-platform-internalDiagram
%%{ init : { "theme" : "default" }}%% graph TD subgraph "airbyte-python-cdk" A["pypi_publish.yml<br/>workflow"]:::major-edit end subgraph "airbyte-platform-internal" B["oss/airbyte-connector-builder-server/<br/>Dockerfile"]:::context C["cloud/airbyte-connector-builder-server-wrapped/<br/>Dockerfile<br/>(DELETED)"]:::context D["oss/airbyte-connector-builder-server/<br/>requirements.in"]:::context end A -->|"updates (preserved)"| B A -.->|"tried to update<br/>(REMOVED)"| C A -->|"updates (preserved)"| D subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
This change resolves the CI failure shown in the Slack thread where the workflow was getting "No such file or directory" errors. The fix is minimal and surgical - only removing the problematic line while preserving all working functionality.
Link to Devin run: https://app.devin.ai/sessions/b70f94c1b76d4e1ea86f759bfe42f44a
Requested by: Aaron ("AJ") Steers (@aaronsteers)