Skip to content

chore: update dependencies for mcp compatability#799

Closed
Patrick Nilan (pnilan) wants to merge 3 commits intomainfrom
pnilan/jsonref/bump-version
Closed

chore: update dependencies for mcp compatability#799
Patrick Nilan (pnilan) wants to merge 3 commits intomainfrom
pnilan/jsonref/bump-version

Conversation

@pnilan
Copy link
Copy Markdown
Contributor

@pnilan Patrick Nilan (pnilan) commented Oct 16, 2025

What

  • To import airbyte-cdk to the mcp repo, I'm updating the jsonref dep to 1.1.0, the breaking changes do not affect its use in the airbyte-cdk package
  • ddtrace 3.12.3 was yanked due to missing commits that were in 3.12.0, therefore, reverting to 3.12.0
  • Updates numpy to 2.4.0.
  • Unpins langchain and langchain-core.

Summary by CodeRabbit

  • Chores
    • Updated dependency constraints to improve compatibility and support newer runtime versions — including JSON handling, numerical computing, tracing, and optional integration packages. These changes aim to enhance stability and broaden supported versions for downstream tools.

Copilot AI review requested due to automatic review settings October 16, 2025 21:47
@github-actions github-actions bot added the chore label Oct 16, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 16, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

Updated dependency constraints in pyproject.toml: jsonref changed from ~0.2 to ^1; numpy from <2 to ^2.0.0; ddtrace from ^3.12.3 to ^3.12.0; langchain and langchain_core pinned to ranged constraints >=... ,<1.0.0.

Changes

Cohort / File(s) Change Summary
Dependency manifest
pyproject.toml
Updated multiple dependency version constraints: jsonref ~0.2^1; numpy <2^2.0.0; ddtrace ^3.12.3^3.12.0; langchain 0.1.16>=0.1.16,<1.0.0; langchain_core 0.1.42>=0.1.42,<1.0.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

dependencies

Have you verified compatibility (local tests/CI) with jsonref ^1 and numpy ^2.0.0, since those are major-version changes—wdyt?

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "chore: update dependencies for mcp compatability" is related to the actual changeset, which includes updates to multiple dependencies (jsonref, ddtrace, langchain, langchain_core, and numpy) with the stated goal of improving MCP compatibility. The title conveys meaningful information about what is being changed and the general purpose, referring to a real aspect of the changes rather than being misleading or off-topic. However, the title is somewhat generic and doesn't capture the specific nature of the main changes outlined in the PR description, which are the jsonref version bump and the ddtrace revert due to yanking.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pnilan/jsonref/bump-version

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 98d45ba and dadb972.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Check: source-intercom
  • GitHub Check: Check: source-hardcoded-records
  • GitHub Check: Check: source-pokeapi
  • GitHub Check: Check: destination-motherduck
  • GitHub Check: Check: source-shopify
  • GitHub Check: MyPy Check
  • GitHub Check: Pytest (All, Python 3.13, Ubuntu)
  • GitHub Check: Pytest (All, Python 3.11, Ubuntu)
  • GitHub Check: SDM Docker Image Build
  • GitHub Check: Manifest Server Docker Image Build

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses dependency version updates to maintain compatibility and stability: bumping jsonref from ~0.2 to ^1 (1.1.0) for airbyte-cdk import compatibility, and reverting ddtrace from ^3.12.3 to 3.12.0 due to the newer version being yanked from PyPI.

Key changes:

  • Updated jsonref to version 1.x with breaking changes confirmed not to affect airbyte-cdk usage
  • Reverted ddtrace to 3.12.0 and removed the optional = true flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread pyproject.toml Outdated
@github-actions
Copy link
Copy Markdown

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Testing This CDK Version

You can test this version of the CDK using the following:

# Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@pnilan/jsonref/bump-version#egg=airbyte-python-cdk[dev]' --help

# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch pnilan/jsonref/bump-version

Helpful Resources

PR Slash Commands

Airbyte Maintainers can execute the following slash commands on your PR:

  • /autofix - Fixes most formatting and linting issues
  • /poetry-lock - Updates poetry.lock file
  • /test - Runs connector tests with the updated CDK
  • /poe build - Regenerate git-committed build artifacts, such as the pydantic models which are generated from the manifest JSON schema in YAML.
  • /poe <command> - Runs any poe command in the CDK environment

📝 Edit this welcome message.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025

PyTest Results (Fast)

1 tests   - 3 801   0 ✅  - 3 790   1s ⏱️ - 6m 31s
1 suites ±    0   0 💤  -    12 
1 files   ±    0   0 ❌ ±    0   1 🔥 +1 

For more details on these errors, see this check.

Results for commit dadb972. ± Comparison against base commit 55ea028.

This pull request removes 3802 and adds 1 tests. Note that renamed tests count towards both.
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config0-expected_calls0]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config1-expected_calls1]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config2-expected_calls2]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config3-expected_calls3]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config4-expected_calls4]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config5-expected_calls5]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config6-expected_calls6]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config7-expected_calls7]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config8-expected_calls8]
unit_tests.cli.airbyte_cdk.test_secrets.TestFetch ‑ test_fetch_with_all_failed_secrets
…
airbyte_cdk.destinations.vector_db_based.test_utils

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 16, 2025

PyTest Results (Full)

3 tests   - 3 802   0 ✅  - 3 793   16s ⏱️ - 10m 59s
1 suites ±    0   0 💤  -    12 
1 files   ±    0   0 ❌ ±    0   3 🔥 +3 

For more details on these errors, see this check.

Results for commit dadb972. ± Comparison against base commit 55ea028.

This pull request removes 3805 and adds 3 tests. Note that renamed tests count towards both.
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config0-expected_calls0]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config1-expected_calls1]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config2-expected_calls2]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config3-expected_calls3]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config4-expected_calls4]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config5-expected_calls5]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config6-expected_calls6]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config7-expected_calls7]
unit_tests.cli.airbyte_cdk.test_secret_masks ‑ test_print_ci_secrets_masks_for_config[config8-expected_calls8]
unit_tests.cli.airbyte_cdk.test_secrets.TestFetch ‑ test_fetch_with_all_failed_secrets
…
airbyte_cdk.destinations.vector_db_based.test_utils
unit_tests.destinations.vector_db_based.embedder_test
unit_tests.destinations.vector_db_based.writer_test

♻️ This comment has been updated with latest results.

@pnilan Patrick Nilan (pnilan) changed the title chore: bump jsonref, revert ddtrace (due to yanking) chore: update dependencies for mcp compatability Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants