chore: Add manifest-server dependency group for independent locking (do not merge)#809
Closed
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit intomainfrom
Closed
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
Original prompt from AJ Steers |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1761175104-manifest-server-dependency-group#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1761175104-manifest-server-dependency-groupHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
PyTest Results (Full)3 805 tests 3 793 ✅ 11m 18s ⏱️ Results for commit 112a453. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: Add manifest-server dependency group for independent locking (do not merge)
Summary
This PR migrates the
manifest-serverdependencies (fastapi, uvicorn, ddtrace) from optional dependencies in the main[tool.poetry.dependencies]section to a dedicated Poetry dependency group[tool.poetry.group.manifest-server.dependencies]. The corresponding extra has been removed from[tool.poetry.extras]and the CI configuration updated to reference it as an optional Poetry group instead.Key changes:
manifest-servergroupmanifest-serverextra definition[tool.airbyte_ci]to include "manifest-server" inoptional_poetry_groupsinstead ofpoetry_extrasGoal: Enable independent locking of manifest-server dependencies to avoid constraint conflicts, specifically to allow numpy >=2.0 (currently blocked by langchain constraints from other extras).
Review & Testing Checklist for Human
pip install airbyte-cdk[manifest-server]will NO LONGER WORK - users would need to use Poetry with--with manifest-serverpip install airbyte-cdk[manifest-server]Test Plan
poetry install --with manifest-servermanifest-server --helpNotes