feat: Add Python 3.13 support to airbyte-cdk#814
feat: Add Python 3.13 support to airbyte-cdk#814David Gold (dbgold17) wants to merge 1 commit intomainfrom
Conversation
- Update Python version constraint from >=3.10,<3.14 to >=3.10,<3.15 - All dependencies are compatible with Python 3.13 - Regenerated poetry.lock with Python 3.13.1 Co-Authored-By: David Gold <32782137+dbgold17@users.noreply.github.com>
Original prompt from David Gold |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds Python 3.13 support to the airbyte-cdk by updating the Python version constraint from >=3.10,<3.14 to >=3.10,<3.15 and regenerating the poetry.lock file.
- Updated Python version constraint in pyproject.toml to include Python 3.13
- Regenerated poetry.lock file with Python 3.13.1 compatibility
- Maintained backward compatibility with Python 3.10, 3.11, and 3.12
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1761259386-python-313-support#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1761259386-python-313-supportHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
📝 WalkthroughWalkthroughUpdates the Python version constraint in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (2)
Comment |
- Update Python version constraint from ^3.10,<3.12 to >=3.10,<3.15 - Update base Docker image to Python 3.13 (python-connector-base:4.1.0) - All 29 unit tests pass with Python 3.13.1 - 3/4 integration tests pass (csv test has pre-existing configuration issue) - Document upgrade process and test results Note: This change depends on airbyte-cdk being published with Python 3.13 support. A separate PR has been created for the CDK: airbytehq/airbyte-python-cdk#814 Co-Authored-By: David Gold <32782137+dbgold17@users.noreply.github.com>
|
this PR was an AI hallucination spawned from a task to update a connector to use python3.13. The CDK already supports python 3.13 |
|
/poetry-lock |
feat: Add Python 3.13 support to airbyte-cdk
Summary
This PR adds Python 3.13 support to the airbyte-python-cdk by broadening the Python version constraint from
>=3.10,<3.14to>=3.10,<3.15and regenerating the poetry.lock file with Python 3.13.1.The change was tested locally with the source-gcs connector, which successfully passed 29/29 unit tests and 3/4 integration tests (the failing test was due to a configuration issue unrelated to Python 3.13 compatibility).
Note: This PR is part of a two-PR series. A corresponding PR for source-gcs will be created once this CDK change is merged and published.
Review & Testing Checklist for Human
python_version <= "3.11" or python_version >= "3.12.0"conditions) - verify these are correctNotes
Summary by CodeRabbit