fix: Register regex_replace and regex_search as Jinja macros for direct function call syntax#905
Closed
Lucas Leadbetter (lleadbet) wants to merge 1 commit intomainfrom
Closed
Conversation
…ct function call syntax Co-Authored-By: lucas.leadbetter@airbyte.io <lucas.leadbetter@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1770924488-fix-regex-replace-macro#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1770924488-fix-regex-replace-macroPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
Contributor
Author
|
Closed per conversation in Slack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Register regex_replace and regex_search as Jinja macros
Summary
regex_replaceandregex_searchwere only registered as Jinja filters (via_ENVIRONMENT.filters), which means they only worked with pipe syntax:This PR adds both functions to the
_macros_listinmacros.py(which feeds_ENVIRONMENT.globals), making them available as direct function calls as well. The functions are imported fromfilters.py— no logic is duplicated.Review & Testing Checklist for Human
macros.py→filters.py(currentlyfilters.pydoes not import frommacros.py, so this should be safe){{ regex_replace('abc123def456', '[0-9]+', '') }}works as a direct function callNotes